Re: [Outreachy kernel] [PATCH] staging: lustre: llite: dir: Add __user annotations to remove sparse warnings

[Arnd Bergmann <arnd@arndb.de>]

On Saturday 31 October 2015 03:56:27 Amitoj Kaur Chawla wrote:
> >> @@ -1244,6 +1244,9 @@ static long ll_dir_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
> >>       struct ll_sb_info *sbi = ll_i2sbi(inode);
> >>       struct obd_ioctl_data *data;
> >>       int rc = 0;
> >> +     int __user *argi = (int __user *)arg;
> >> +     void __user *argv = (void __user *)arg;
> >> +     char __user *argc = (char __user *)arg;
> >
> > I don't think you need three different variables.  A void * should be good
> > everywhere?  argv is also sort of a strange name.  Maybe buf?
> >
> > julia
> >
> >>
> >>
> 
> I thought so too that void is enough and I did that initially, but it
> gives errors when I change this:
> 
>                return put_user(inode->i_generation, (int *)arg);
> 
> 

Right, put_user() is a macro that needs an argument of the
correct type. Maybe call it 'intarg'?

I think the argc is not needed though, the other functions can
take a void pointer as far as I can tell.

	Arnd