From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 11/22] drm/i915: Introduce a mutex for file_priv->context_idr Date: Mon, 18 Mar 2019 16:45:41 +0000 Message-ID: <657ffbbf-57c0-77fb-368a-94aa94ba8a37@linux.intel.com> References: <20190318095204.9913-1-chris@chris-wilson.co.uk> <20190318095204.9913-11-chris@chris-wilson.co.uk> <155292692638.4168.18419482231981249177@skylake-alporthouse-com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 333198967B for ; Mon, 18 Mar 2019 16:45:44 +0000 (UTC) In-Reply-To: <155292692638.4168.18419482231981249177@skylake-alporthouse-com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE4LzAzLzIwMTkgMTY6MzUsIENocmlzIFdpbHNvbiB3cm90ZToKPiBRdW90aW5nIFR2cnRr byBVcnN1bGluICgyMDE5LTAzLTE4IDE2OjI4OjM1KQo+Pgo+PiBPbiAxOC8wMy8yMDE5IDA5OjUx LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+PiBEZWZpbmUgYSBtdXRleCBmb3IgdGhlIGV4Y2x1c2l2 ZSB1c2Ugb2YgaW50ZXJhY3Rpbmcgd2l0aCB0aGUgcGVyLWZpbGUKPj4+IGNvbnRleHQtaWRyLCB0 aGF0IHdhcyBwcmV2aW91c2x5IGd1YXJkZWQgYnkgc3RydWN0X211dGV4LiBUaGlzIGFsbG93cyB1 cwo+Pj4gdG8gcmVkdWNlIHRoZSBjb3ZlcmFnZSBvZiBzdHJ1Y3RfbXV0ZXgsIHdpdGggYSB2aWV3 IHRvIHJlbW92aW5nIHRoZSBsYXN0Cj4+PiBiaXRzIGNvb3JkaW5hdGluZyBHRU0gY29udGV4dCBs YXRlci4gKEluIHRoZSBzaG9ydCB0ZXJtLCB3ZSBhdm9pZCB0YWtpbmcKPj4+IHN0cnVjdF9tdXRl eCB3aGlsZSB1c2luZyB0aGUgZXh0ZW5kZWQgY29uc3RydWN0b3IgZnVuY3Rpb25zLCBwcmV2ZW50 aW5nCj4+PiBzb21lIG5hc3R5IHJlY3Vyc2lvbi4pCj4+Pgo+Pj4gU2lnbmVkLW9mZi1ieTogQ2hy aXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4+PiBDYzogVHZydGtvIFVyc3Vs aW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KPj4+IC0tLQo+Pj4gICAgZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9kcnYuaCAgICAgICAgIHwgIDIgKysKPj4+ICAgIGRyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZ2VtX2NvbnRleHQuYyB8IDQzICsrKysrKysrKysrLS0tLS0tLS0tLS0tLS0K Pj4+ICAgIDIgZmlsZXMgY2hhbmdlZCwgMjEgaW5zZXJ0aW9ucygrKSwgMjQgZGVsZXRpb25zKC0p Cj4+Pgo+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4+PiBpbmRleCA4NjA4MGE2ZTBmNDUuLjkw Mzg5MzMzZGQ0NyAxMDA2NDQKPj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2 LmgKPj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPj4+IEBAIC0yMTYs NyArMjE2LDkgQEAgc3RydWN0IGRybV9pOTE1X2ZpbGVfcHJpdmF0ZSB7Cj4+PiAgICAgKi8KPj4+ ICAgICNkZWZpbmUgRFJNX0k5MTVfVEhST1RUTEVfSklGRklFUyBtc2Vjc190b19qaWZmaWVzKDIw KQo+Pj4gICAgICAgIH0gbW07Cj4+PiArCj4+PiAgICAgICAgc3RydWN0IGlkciBjb250ZXh0X2lk cjsKPj4+ICsgICAgIHN0cnVjdCBtdXRleCBjb250ZXh0X2xvY2s7IC8qIGd1YXJkcyBjb250ZXh0 X2lkciAqLwo+Pgo+PiBjb250ZXh0X2lkcl9sb2NrIHRoZW4/Cj4+Cj4+PiAgICAKPj4+ICAgICAg ICB1bnNpZ25lZCBpbnQgYnNkX2VuZ2luZTsKPj4+ICAgIAo+Pj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2NvbnRleHQuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfZ2VtX2NvbnRleHQuYwo+Pj4gaW5kZXggNWRmM2Q0MjNlYzZjLi45NGM0NjZkNGIyOWUg MTAwNjQ0Cj4+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9jb250ZXh0LmMK Pj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2NvbnRleHQuYwo+Pj4gQEAg LTU3OSw5ICs1NzksNyBAQCB2b2lkIGk5MTVfZ2VtX2NvbnRleHRzX2Zpbmkoc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmk5MTUpCj4+PiAgICAKPj4+ICAgIHN0YXRpYyBpbnQgY29udGV4dF9pZHJf Y2xlYW51cChpbnQgaWQsIHZvaWQgKnAsIHZvaWQgKmRhdGEpCj4+PiAgICB7Cj4+PiAtICAgICBz dHJ1Y3QgaTkxNV9nZW1fY29udGV4dCAqY3R4ID0gcDsKPj4+IC0KPj4+IC0gICAgIGNvbnRleHRf Y2xvc2UoY3R4KTsKPj4+ICsgICAgIGNvbnRleHRfY2xvc2UocCk7Cj4+PiAgICAgICAgcmV0dXJu IDA7Cj4+PiAgICB9Cj4+PiAgICAKPj4+IEBAIC01OTYsOCArNTk0LDEwIEBAIHN0YXRpYyBpbnQg Z2VtX2NvbnRleHRfcmVnaXN0ZXIoc3RydWN0IGk5MTVfZ2VtX2NvbnRleHQgKmN0eCwKPj4+ICAg ICAgICAgICAgICAgIGN0eC0+cHBndHQtPnZtLmZpbGUgPSBmcHJpdjsKPj4+ICAgIAo+Pj4gICAg ICAgIC8qIEFuZCAobmVhcmx5KSBmaW5hbGx5IGV4cG9zZSBvdXJzZWx2ZXMgdG8gdXNlcnNwYWNl IHZpYSB0aGUgaWRyICovCj4+PiArICAgICBtdXRleF9sb2NrKCZmcHJpdi0+Y29udGV4dF9sb2Nr KTsKPj4+ICAgICAgICByZXQgPSBpZHJfYWxsb2MoJmZwcml2LT5jb250ZXh0X2lkciwgY3R4LAo+ Pj4gICAgICAgICAgICAgICAgICAgICAgICBERUZBVUxUX0NPTlRFWFRfSEFORExFLCAwLCBHRlBf S0VSTkVMKTsKPj4+ICsgICAgIG11dGV4X3VubG9jaygmZnByaXYtPmNvbnRleHRfbG9jayk7Cj4+ PiAgICAgICAgaWYgKHJldCA8IDApCj4+PiAgICAgICAgICAgICAgICBnb3RvIGVycl9waWQ7Cj4+ PiAgICAKPj4+IEBAIC02MTYsNyArNjE2LDkgQEAgc3RhdGljIGludCBnZW1fY29udGV4dF9yZWdp c3RlcihzdHJ1Y3QgaTkxNV9nZW1fY29udGV4dCAqY3R4LAo+Pj4gICAgICAgIHJldHVybiAwOwo+ Pj4gICAgCj4+PiAgICBlcnJfaWRyOgo+Pj4gKyAgICAgbXV0ZXhfbG9jaygmZnByaXYtPmNvbnRl eHRfbG9jayk7Cj4+PiAgICAgICAgaWRyX3JlbW92ZSgmZnByaXYtPmNvbnRleHRfaWRyLCBjdHgt PnVzZXJfaGFuZGxlKTsKPj4+ICsgICAgIG11dGV4X3VubG9jaygmZnByaXYtPmNvbnRleHRfbG9j ayk7Cj4+PiAgICAgICAgY3R4LT5maWxlX3ByaXYgPSBOVUxMOwo+Pj4gICAgZXJyX3BpZDoKPj4+ ICAgICAgICBwdXRfcGlkKGN0eC0+cGlkKTsKPj4+IEBAIC02MzIsMTAgKzYzNCwxMSBAQCBpbnQg aTkxNV9nZW1fY29udGV4dF9vcGVuKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1LAo+Pj4g ICAgICAgIGludCBlcnI7Cj4+PiAgICAKPj4+ICAgICAgICBpZHJfaW5pdCgmZmlsZV9wcml2LT5j b250ZXh0X2lkcik7Cj4+PiArICAgICBtdXRleF9pbml0KCZmaWxlX3ByaXYtPmNvbnRleHRfbG9j ayk7Cj4+PiAgICAKPj4+ICAgICAgICBtdXRleF9sb2NrKCZpOTE1LT5kcm0uc3RydWN0X211dGV4 KTsKPj4+IC0KPj4+ICAgICAgICBjdHggPSBpOTE1X2dlbV9jcmVhdGVfY29udGV4dChpOTE1KTsK Pj4+ICsgICAgIG11dGV4X3VubG9jaygmaTkxNS0+ZHJtLnN0cnVjdF9tdXRleCk7Cj4+PiAgICAg ICAgaWYgKElTX0VSUihjdHgpKSB7Cj4+PiAgICAgICAgICAgICAgICBlcnIgPSBQVFJfRVJSKGN0 eCk7Cj4+PiAgICAgICAgICAgICAgICBnb3RvIGVycjsKPj4+IEBAIC02NDgsMTQgKzY1MSwxNCBA QCBpbnQgaTkxNV9nZW1fY29udGV4dF9vcGVuKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1 LAo+Pj4gICAgICAgIEdFTV9CVUdfT04oY3R4LT51c2VyX2hhbmRsZSAhPSBERUZBVUxUX0NPTlRF WFRfSEFORExFKTsKPj4+ICAgICAgICBHRU1fQlVHX09OKGk5MTVfZ2VtX2NvbnRleHRfaXNfa2Vy bmVsKGN0eCkpOwo+Pj4gICAgCj4+PiAtICAgICBtdXRleF91bmxvY2soJmk5MTUtPmRybS5zdHJ1 Y3RfbXV0ZXgpOwo+Pj4gLQo+Pj4gICAgICAgIHJldHVybiAwOwo+Pj4gICAgCj4+PiAgICBlcnJf Y3R4Ogo+Pj4gKyAgICAgbXV0ZXhfbG9jaygmaTkxNS0+ZHJtLnN0cnVjdF9tdXRleCk7Cj4+PiAg ICAgICAgY29udGV4dF9jbG9zZShjdHgpOwo+Pj4gLWVycjoKPj4+ICAgICAgICBtdXRleF91bmxv Y2soJmk5MTUtPmRybS5zdHJ1Y3RfbXV0ZXgpOwo+Pj4gK2VycjoKPj4+ICsgICAgIG11dGV4X2Rl c3Ryb3koJmZpbGVfcHJpdi0+Y29udGV4dF9sb2NrKTsKPj4+ICAgICAgICBpZHJfZGVzdHJveSgm ZmlsZV9wcml2LT5jb250ZXh0X2lkcik7Cj4+PiAgICAgICAgcmV0dXJuIFBUUl9FUlIoY3R4KTsK Pj4+ICAgIH0KPj4+IEBAIC02NjgsNiArNjcxLDcgQEAgdm9pZCBpOTE1X2dlbV9jb250ZXh0X2Ns b3NlKHN0cnVjdCBkcm1fZmlsZSAqZmlsZSkKPj4+ICAgIAo+Pj4gICAgICAgIGlkcl9mb3JfZWFj aCgmZmlsZV9wcml2LT5jb250ZXh0X2lkciwgY29udGV4dF9pZHJfY2xlYW51cCwgTlVMTCk7Cj4+ PiAgICAgICAgaWRyX2Rlc3Ryb3koJmZpbGVfcHJpdi0+Y29udGV4dF9pZHIpOwo+Pj4gKyAgICAg bXV0ZXhfZGVzdHJveSgmZmlsZV9wcml2LT5jb250ZXh0X2xvY2spOwo+Pj4gICAgfQo+Pj4gICAg Cj4+PiAgICBzdGF0aWMgc3RydWN0IGk5MTVfcmVxdWVzdCAqCj4+PiBAQCAtODUwLDI1ICs4NTQs MjIgQEAgaW50IGk5MTVfZ2VtX2NvbnRleHRfY3JlYXRlX2lvY3RsKHN0cnVjdCBkcm1fZGV2aWNl ICpkZXYsIHZvaWQgKmRhdGEsCj4+PiAgICAgICAgICAgICAgICByZXR1cm4gcmV0Owo+Pj4gICAg Cj4+PiAgICAgICAgY3R4ID0gaTkxNV9nZW1fY3JlYXRlX2NvbnRleHQoaTkxNSk7Cj4+PiAtICAg ICBpZiAoSVNfRVJSKGN0eCkpIHsKPj4+IC0gICAgICAgICAgICAgcmV0ID0gUFRSX0VSUihjdHgp Owo+Pj4gLSAgICAgICAgICAgICBnb3RvIGVycl91bmxvY2s7Cj4+PiAtICAgICB9Cj4+PiArICAg ICBtdXRleF91bmxvY2soJmRldi0+c3RydWN0X211dGV4KTsKPj4+ICsgICAgIGlmIChJU19FUlIo Y3R4KSkKPj4+ICsgICAgICAgICAgICAgcmV0dXJuIFBUUl9FUlIoY3R4KTsKPj4+ICAgIAo+Pj4g ICAgICAgIHJldCA9IGdlbV9jb250ZXh0X3JlZ2lzdGVyKGN0eCwgZmlsZV9wcml2KTsKPj4+ICAg ICAgICBpZiAocmV0KQo+Pj4gICAgICAgICAgICAgICAgZ290byBlcnJfY3R4Owo+Pj4gICAgCj4+ PiAtICAgICBtdXRleF91bmxvY2soJmRldi0+c3RydWN0X211dGV4KTsKPj4+IC0KPj4+ICAgICAg ICBhcmdzLT5jdHhfaWQgPSBjdHgtPnVzZXJfaGFuZGxlOwo+Pj4gICAgICAgIERSTV9ERUJVRygi SFcgY29udGV4dCAlZCBjcmVhdGVkXG4iLCBhcmdzLT5jdHhfaWQpOwo+Pj4gICAgCj4+PiAgICAg ICAgcmV0dXJuIDA7Cj4+PiAgICAKPj4+ICAgIGVycl9jdHg6Cj4+PiArICAgICBtdXRleF9sb2Nr KCZkZXYtPnN0cnVjdF9tdXRleCk7Cj4+PiAgICAgICAgY29udGV4dF9jbG9zZShjdHgpOwo+Pj4g LWVycl91bmxvY2s6Cj4+PiAgICAgICAgbXV0ZXhfdW5sb2NrKCZkZXYtPnN0cnVjdF9tdXRleCk7 Cj4+PiAgICAgICAgcmV0dXJuIHJldDsKPj4+ICAgIH0KPj4+IEBAIC04NzksNyArODgwLDYgQEAg aW50IGk5MTVfZ2VtX2NvbnRleHRfZGVzdHJveV9pb2N0bChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2 LCB2b2lkICpkYXRhLAo+Pj4gICAgICAgIHN0cnVjdCBkcm1faTkxNV9nZW1fY29udGV4dF9kZXN0 cm95ICphcmdzID0gZGF0YTsKPj4+ICAgICAgICBzdHJ1Y3QgZHJtX2k5MTVfZmlsZV9wcml2YXRl ICpmaWxlX3ByaXYgPSBmaWxlLT5kcml2ZXJfcHJpdjsKPj4+ICAgICAgICBzdHJ1Y3QgaTkxNV9n ZW1fY29udGV4dCAqY3R4Owo+Pj4gLSAgICAgaW50IHJldDsKPj4+ICAgIAo+Pj4gICAgICAgIGlm IChhcmdzLT5wYWQgIT0gMCkKPj4+ICAgICAgICAgICAgICAgIHJldHVybiAtRUlOVkFMOwo+Pj4g QEAgLTg4NywyMSArODg3LDE2IEBAIGludCBpOTE1X2dlbV9jb250ZXh0X2Rlc3Ryb3lfaW9jdGwo c3RydWN0IGRybV9kZXZpY2UgKmRldiwgdm9pZCAqZGF0YSwKPj4+ICAgICAgICBpZiAoYXJncy0+ Y3R4X2lkID09IERFRkFVTFRfQ09OVEVYVF9IQU5ETEUpCj4+PiAgICAgICAgICAgICAgICByZXR1 cm4gLUVOT0VOVDsKPj4+ICAgIAo+Pj4gLSAgICAgY3R4ID0gaTkxNV9nZW1fY29udGV4dF9sb29r dXAoZmlsZV9wcml2LCBhcmdzLT5jdHhfaWQpOwo+Pj4gKyAgICAgbXV0ZXhfbG9jaygmZmlsZV9w cml2LT5jb250ZXh0X2xvY2spOwo+Pj4gKyAgICAgY3R4ID0gaWRyX3JlbW92ZSgmZmlsZV9wcml2 LT5jb250ZXh0X2lkciwgYXJncy0+Y3R4X2lkKTsKPj4+ICsgICAgIG11dGV4X2xvY2soJmZpbGVf cHJpdi0+Y29udGV4dF9sb2NrKTsKPj4+ICAgICAgICBpZiAoIWN0eCkKPj4+ICAgICAgICAgICAg ICAgIHJldHVybiAtRU5PRU5UOwo+Pj4gICAgCj4+PiAtICAgICByZXQgPSBtdXRleF9sb2NrX2lu dGVycnVwdGlibGUoJmRldi0+c3RydWN0X211dGV4KTsKPj4+IC0gICAgIGlmIChyZXQpCj4+PiAt ICAgICAgICAgICAgIGdvdG8gb3V0Owo+Pj4gLQo+Pj4gLSAgICAgaWRyX3JlbW92ZSgmZmlsZV9w cml2LT5jb250ZXh0X2lkciwgY3R4LT51c2VyX2hhbmRsZSk7Cj4+PiArICAgICBtdXRleF9sb2Nr KCZkZXYtPnN0cnVjdF9tdXRleCk7Cj4+Cj4+IEknZCBrZWVwIHRoaXMgb25lIGludGVycnVwdGli bGUuIEhtIGJ1bW1lciwgdGhlcmUgd2FzIG1vcmUgb2YgdGhlbSBiZWZvcmUuLgo+IAo+IEF0IHRo aXMgcG9pbnQsIGludGVycnVwdCBoYW5kbGluZyBiZWNvbWVzIHByb2JsZW1hdGljLCBhcyB3ZSBo YXZlIHRvCj4gdGhlbiByZS1pbnNlcnQgdGhlIGN0eF9pZCBpbnRvIHRoZSBpZHIgYW5kIHRoYXQg bWF5IGhhdmUgYWxyZWFkeSBiZWVuCj4gY2xhaW1lZCBlbHNld2hlcmUuCgpVZ2gsIGJhZC4uIENh biB3ZSBoYXZlIHN0cnVjdF9tdXRleCBuZXN0IHVuZGVyIHRoZSBjb250ZXh0X2lkcl9sb2NrPwoK UmVnYXJkcywKClR2cnRrbwoKPj4gSSBtZWFuIHRoZSBuZXcgbXV0ZXggd2UgY2FuIHByb2JhYmx5 IGdldCBhd2F5IGJ5IG5vdCBib3RoZXJpbmcsIHNpbmNlIGl0Cj4+IGd1YXJkcyBzbyBsaXR0bGUs IGJ1dCBzdHJ1Y3QgbXV0ZXgsIHNpbmNlIHlvdSBhcmUgdG91Y2hpbmcgdGhvc2UgbGluZXMKPj4g YW55d2F5LCB3aGF0IGRvIHlvdSB0aGluayBhYm91dCBtYWtpbmcgaXQgaW50ZXJydXB0aWJsZSBp biBhbGwgaW9jdGwgcGF0aHM/Cj4gCj4gTm90IHByYWN0aWNhbCBpbW87IGJ1dCB3ZSB3b24ndCBu ZWVkIHN0cnVjdF9tdXRleCBoZXJlIGluIGFib3V0IGFub3RoZXIgMjAKPiBwYXRjaGVzIDopCj4g LUNocmlzCj4gCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA==