All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linpu Yu <linpu5433@gmail.com>
To: kerneljasonxing@gmail.com, magnus.karlsson@intel.com,
	maciej.fijalkowski@intel.com, netdev@vger.kernel.org,
	bpf@vger.kernel.org
Cc: sdf@fomichev.me, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
	ast@kernel.org, daniel@iogearbox.net, hawk@kernel.org,
	john.fastabend@gmail.com, bjorn@kernel.org,
	linux-kernel@vger.kernel.org, tanyuan98@outlook.com,
	yifanwucs@gmail.com
Subject: Re: [PATCH v2 bpf 1/1] xskmap: reject TX-only AF_XDP sockets
Date: Tue, 28 Apr 2026 20:21:58 +0800	[thread overview]
Message-ID: <65911f89-e1ef-4da1-aa41-d261e5162f71@gmail.com> (raw)
In-Reply-To: <2b156bc4277a9e891f3399935416701d1f9efd7c.1777276241.git.linpu5433@gmail.com>

Thanks for catching this. fbfc504a24f5 is not the correct Fixes target.

At that point, AF_XDP did not yet have TX ring support in the UAPI, and
xsk_bind() also required xs->rx to exist, so a TX-only socket was not
constructible there.

Tx queue support came later in f61459030ec7 ("xsk: add Tx queue setup and
mmap support"), but XSKMAP updates still rejected sockets without an Rx
ring via xsk_is_setup_for_bpf_map().

The regression was introduced when 968be23ceaca removed that check.
I have corrected the Fixes tag accordingly in v3.


  parent reply	other threads:[~2026-04-28 12:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-27  9:44 [PATCH v2 bpf 1/1] xskmap: reject TX-only AF_XDP sockets Linpu Yu
2026-04-27 10:23 ` bot+bpf-ci
2026-04-28 12:21 ` Linpu Yu [this message]
2026-04-28 12:54 ` [PATCH bpf-next v3] " Linpu Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=65911f89-e1ef-4da1-aa41-d261e5162f71@gmail.com \
    --to=linpu5433@gmail.com \
    --cc=ast@kernel.org \
    --cc=bjorn@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hawk@kernel.org \
    --cc=horms@kernel.org \
    --cc=john.fastabend@gmail.com \
    --cc=kerneljasonxing@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maciej.fijalkowski@intel.com \
    --cc=magnus.karlsson@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sdf@fomichev.me \
    --cc=tanyuan98@outlook.com \
    --cc=yifanwucs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.