RE: [PATCH bpf 1/3] s390/bpf: Fix gotol with large offsets

[John Fastabend <john.fastabend@gmail.com>]

Ilya Leoshkevich wrote:
> The gotol implementation uses a wrong data type for the offset: it
> should be s32, not s16.
> 
> Fixes: c690191e23d8 ("s390/bpf: Implement unconditional jump with 32-bit offset")
> Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
> ---
>  arch/s390/net/bpf_jit_comp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/s390/net/bpf_jit_comp.c b/arch/s390/net/bpf_jit_comp.c
> index bf06b7283f0c..c7fbeedeb0a4 100644
> --- a/arch/s390/net/bpf_jit_comp.c
> +++ b/arch/s390/net/bpf_jit_comp.c
> @@ -779,7 +779,7 @@ static noinline int bpf_jit_insn(struct bpf_jit *jit, struct bpf_prog *fp,
>  				 int i, bool extra_pass, u32 stack_depth)
>  {
>  	struct bpf_insn *insn = &fp->insnsi[i];
> -	s16 branch_oc_off = insn->off;
> +	s32 branch_oc_off = insn->off;
>  	u32 dst_reg = insn->dst_reg;
>  	u32 src_reg = insn->src_reg;
>  	int last, insn_count = 1;
> -- 
> 2.43.0
> 
> 

Acked-by: John Fastabend <john.fastabend@gmail.com>