From: Sinan Kaya <okaya@kernel.org>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
Alexey Kardashevskiy <aik@ozlabs.ru>,
Peter Xu <peterx@redhat.com>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>
Subject: Re: [PATCH v2 6/6] PCI: Expose reset type to users of pci_reset_bus()
Date: Fri, 14 Sep 2018 18:52:37 -0400 [thread overview]
Message-ID: <65a9cc69-fd96-fa45-e271-cf2c7b1adb75@kernel.org> (raw)
In-Reply-To: <20180914163321.2abba9fa@t450s.home>
On 9/14/2018 6:33 PM, Alex Williamson wrote:
>> @@ -1015,7 +1015,7 @@ static long vfio_pci_ioctl(void *device_data,
>> &info, slot);
>> if (!ret)
>> /* User has access, do the reset */
>> - ret = pci_reset_bus(vdev->pdev);
>> + ret = pci_reset_bus(vdev->pdev, PCI_RESET_LINK);
> This should have switched back the control we had prior to 811c5cb37df4
> with something like:
>
> ret = pci_reset_bus(vdev->pdev,
> slot ? PCI_RESET_SLOT : PCI_RESET_BUS);
>
>>
>> hot_reset_release:
>> for (i--; i >= 0; i--)
>> @@ -1390,7 +1390,7 @@ static void vfio_pci_try_bus_reset(struct vfio_pci_device *vdev)
>> }
>>
>> if (needs_reset)
>> - ret = pci_reset_bus(vdev->pdev);
>> + ret = pci_reset_bus(vdev->pdev, PCI_RESET_LINK);
> Same here.
Sure I can do that.
prev parent reply other threads:[~2018-09-15 4:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-14 21:18 [PATCH v2 0/6] PCI: Add reset type parameter to PCI reset functions Sinan Kaya
2018-09-14 21:18 ` [PATCH v2 1/6] PCI: Expose reset_type to users of __pci_reset_function_locked() Sinan Kaya
2018-09-14 22:27 ` Alex Williamson
2018-09-14 22:57 ` Sinan Kaya
2018-09-14 21:18 ` [PATCH v2 2/6] PCI: Expose reset_type to users of pci_reset_function() Sinan Kaya
2018-09-14 21:52 ` Srinivas Pandruvada
2018-09-14 23:20 ` Sinan Kaya
2018-09-15 1:48 ` Srinivas Pandruvada
2018-09-14 21:18 ` [PATCH v2 3/6] PCI: Expose reset_type to users of pci_reset_function_locked() Sinan Kaya
2018-09-14 21:18 ` [PATCH v2 4/6] PCI: Expose reset type to users of pci_try_reset_function() Sinan Kaya
2018-09-14 21:18 ` [PATCH v2 5/6] PCI: Expose reset type to users of pci_probe_reset_function() Sinan Kaya
2018-09-14 21:18 ` [PATCH v2 6/6] PCI: Expose reset type to users of pci_reset_bus() Sinan Kaya
2018-09-14 22:33 ` Alex Williamson
2018-09-14 22:52 ` Sinan Kaya [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65a9cc69-fd96-fa45-e271-cf2c7b1adb75@kernel.org \
--to=okaya@kernel.org \
--cc=aik@ozlabs.ru \
--cc=alex.williamson@redhat.com \
--cc=bhelgaas@google.com \
--cc=gustavo@embeddedor.com \
--cc=linux-pci@vger.kernel.org \
--cc=peterx@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.