From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00B6FC4742C for ; Tue, 3 Nov 2020 00:25:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BAAB62225E for ; Tue, 3 Nov 2020 00:25:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726685AbgKCAZJ (ORCPT ); Mon, 2 Nov 2020 19:25:09 -0500 Received: from mga17.intel.com ([192.55.52.151]:32167 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725940AbgKCAZI (ORCPT ); Mon, 2 Nov 2020 19:25:08 -0500 IronPort-SDR: fksL/kJrKMtwA5KKrEcNfCWeNKIxBWndXMct05r3tYMmTRmdq4QuW92xuL4IVUMq5Y0Ra9vjD2 1UOQLWztjh0g== X-IronPort-AV: E=McAfee;i="6000,8403,9793"; a="148830433" X-IronPort-AV: E=Sophos;i="5.77,446,1596524400"; d="scan'208";a="148830433" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2020 16:25:08 -0800 IronPort-SDR: N2crK+f4x89X2qScEdC1gVaCW8ZW4o3XW3OVcUPCZzDjzpSprZiJc2zcA1Ptp+oQyIKfqPyWj0 PkA/yXXb4Zqw== X-IronPort-AV: E=Sophos;i="5.77,446,1596524400"; d="scan'208";a="538226605" Received: from jekeller-mobl1.amr.corp.intel.com (HELO [10.254.181.231]) ([10.254.181.231]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2020 16:25:07 -0800 Subject: Re: [net-next 14/15] ice: join format strings to same line as ice_debug To: Saeed Mahameed , Tony Nguyen , davem@davemloft.net, kuba@kernel.org Cc: netdev@vger.kernel.org, sassmann@redhat.com, Aaron Brown References: <20201102222338.1442081-1-anthony.l.nguyen@intel.com> <20201102222338.1442081-15-anthony.l.nguyen@intel.com> From: Jacob Keller Organization: Intel Corporation Message-ID: <65aceb04-c39d-facf-efaa-aa28ed480cae@intel.com> Date: Mon, 2 Nov 2020 16:25:04 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 11/2/2020 3:07 PM, Saeed Mahameed wrote: > On Mon, 2020-11-02 at 14:23 -0800, Tony Nguyen wrote: >> From: Jacob Keller >> >> When printing messages with ice_debug, align the printed string to >> the >> origin line of the message in order to ease debugging and tracking >> messages back to their source. >> > > Just out of curiosity, you are only re-aligning the code and not the > printed messages themselves. How would this help ? did you mean help > with tracking the sources when doing grep like operations on the source > code ? > The primary motivation is that the line number of the string now matches the line number of the debug function statement, so there is better alignment when using these line numbers with the dynamic debug messaging system. It's also a style thing, that came up on the list for some patches I wrote for the ice flash update.. it was suggested to just keep the message on the same line as the function. I felt that it was better to go ahead and fix all of these files, so that future code is more likely to use the preferred style rather than follow the pattern of older code. Thanks, Jake