From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pierre-Louis Bossart Subject: Re: ASoC: Intel: sst: Missing IRQ at index 5 on BYT-T device Date: Wed, 19 Dec 2018 10:54:55 -0600 Message-ID: <65b445e8-2202-0554-b920-97ce0f7833ce@linux.intel.com> References: <3b96d716-1d9f-a569-2afa-82b386e752e4@linux.intel.com> <20181217181729.GB845@gerhold.net> <20181217191054.GA10938@gerhold.net> <20181217203242.GB10938@gerhold.net> <20181217204320.GC10938@gerhold.net> <86b92282-5bc1-b8de-93e7-97e7ee17db4b@linux.intel.com> <20181219130747.GA83656@gerhold.net> <20181219150103.GA52375@gerhold.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by alsa0.perex.cz (Postfix) with ESMTP id 891A5267ABE for ; Wed, 19 Dec 2018 17:54:57 +0100 (CET) In-Reply-To: <20181219150103.GA52375@gerhold.net> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Stephan Gerhold Cc: Liam Girdwood , Hans de Goede , alsa-devel@alsa-project.org, Mark Brown , Jie Yang List-Id: alsa-devel@alsa-project.org > > -static int is_byt_cr(struct device *dev, bool *bytcr) > +static int is_byt_cr(struct platform_device *pdev, bool *bytcr) > { > + struct device *dev = &pdev->dev; > int status = 0; > > + if (platform_get_resource(pdev, IORESOURCE_IRQ, 5) == NULL) { > + /* This message is even shown if the device would be detected as BYT-CR below */ > + dev_info(dev, "Falling back to Baytrail-CR platform\n"); > + *bytcr = true; > + return status; > + } > + > if (IS_ENABLED(CONFIG_IOSF_MBI)) { > u32 bios_status; This would be my preferred solution but if it doesn't work as Hans mentions it then we need to think of alternatives. Baytrail platforms are so different (BIOS and hardware) that I don't think we'll manage to pull this off without quirks.