From: Dan Williams <dan.j.williams@intel.com>
To: "Fabio M. De Francesco"
<fabio.maria.de.francesco@linux.intel.com>,
"Peter Zijlstra" <peterz@infradead.org>,
<dan.j.williams@intel.com>
Cc: <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@kernel.org>,
<linux-cxl@vger.kernel.org>, Ira Weiny <ira.weiny@intel.com>
Subject: Re: [RFC PATCH v3] cleanup: Add cond_guard() to conditional guards
Date: Wed, 31 Jan 2024 17:12:12 -0800 [thread overview]
Message-ID: <65baefec49c1a_4e7f52946b@dwillia2-xfh.jf.intel.com.notmuch> (raw)
In-Reply-To: <6168759.DvuYhMxLoT@fdefranc-mobl3>
Fabio M. De Francesco wrote:
> I just noticed that this is not the final version. It misses a semicolon.
> Please discard this v3. I'm sending v4.
Ok, but do please copy the aspect of scoped_conf_guard() to take a
"_fail" statement argument. Passing a return code collector variable by
reference just feels a bit too magical. I like the explicitness of
passing the statement directly.
next prev parent reply other threads:[~2024-02-01 1:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 13:37 [RFC PATCH v3] cleanup: Add cond_guard() to conditional guards Fabio M. De Francesco
2024-02-01 1:08 ` Fabio M. De Francesco
2024-02-01 1:12 ` Dan Williams [this message]
2024-02-01 1:25 ` Fabio M. De Francesco
2024-02-01 8:16 ` Fabio M. De Francesco
2024-02-01 11:36 ` Jonathan Cameron
2024-02-01 15:13 ` Fabio M. De Francesco
2024-02-01 15:32 ` Fabio M. De Francesco
2024-02-01 16:05 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65baefec49c1a_4e7f52946b@dwillia2-xfh.jf.intel.com.notmuch \
--to=dan.j.williams@intel.com \
--cc=fabio.maria.de.francesco@linux.intel.com \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.