From: Andrew Kanner <andrew.kanner@gmail.com>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org,
mchehab@kernel.org
Subject: Re: [PATCH v1] module.h: define __symbol_get_gpl() as a regular __symbol_get()
Date: Tue, 13 Feb 2024 14:10:45 +0300 [thread overview]
Message-ID: <65cbe0ee.050a0220.1c11e.d156@mx.google.com> (raw)
In-Reply-To: <ZbvfYqIKKWkTWLf9@bombadil.infradead.org>
On Thu, Feb 01, 2024 at 10:13:54AM -0800, Luis Chamberlain wrote:
>
> While you're at it, if you want to try it, you could see if you can
> improve the situation more by looking at symbol_get() users that remain
> and seeing if you can instead fix it with proper Kconfig dependency and
> at build time. Then we can just remove it as well.
>
> Luis
Sorry for the late reply.
Luis, can you give more details of your idea? I re-read it once, then
came back and still don't understand.
I see that there are ~10 users for symbol_get() currently. Do you want
to stringify symbol names at build time to completely remove
symbol_get() from module.h? Correct me if I'm wrong since using of a
fuction which is not declared anywhere sounds confusing.
--
Andrew Kanner
next prev parent reply other threads:[~2024-02-13 21:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 19:02 [PATCH v1] module.h: define __symbol_get_gpl() as a regular __symbol_get() Andrew Kanner
2024-02-01 5:29 ` Christoph Hellwig
2024-02-01 9:29 ` Andrew Kanner
2024-02-01 18:13 ` Luis Chamberlain
2024-02-13 11:10 ` Andrew Kanner [this message]
2024-03-12 22:25 ` Luis Chamberlain
2024-03-13 1:12 ` Luis Chamberlain
2024-02-02 7:27 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65cbe0ee.050a0220.1c11e.d156@mx.google.com \
--to=andrew.kanner@gmail.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.