From: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: Matthew Auld <matthew.auld@intel.com>
Subject: Re: [PATCH] drm/i915/perf: Initialise dynamic sysfs group before creation
Date: Wed, 9 Aug 2017 16:14:58 +0100 [thread overview]
Message-ID: <65d93b16-e9d1-53bb-5a49-fa6e48b87584@intel.com> (raw)
In-Reply-To: <150229097876.32436.2860913770184189254@mail.alporthouse.com>
On 09/08/17 16:02, Chris Wilson wrote:
> Quoting Lionel Landwerlin (2017-08-09 15:57:59)
>> Right, that's exactly what I was asking in our previous exchange.
> I just follow the traces, and am internally screaming at how much we are
> stuffing inside drm_i915_private nowadays.
>
>> You need to leave the memset() I think, because we check further down
> It is already zeroed.
>
>> that function that id == 0 to detect failure to recognize that the (Gen,
>> GT) is supported.
>> Unless there is a guarantee that dev_priv is fully memset()?
> It is allocated using kzalloc() and we depend upon that in many, many
> places.
> -Chris
>
Cool,
Fixes: f89823c21224 ("drm/i915/perf: Implement
I915_PERF_ADD/REMOVE_CONFIG interface")
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-08-09 15:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-09 14:47 [PATCH] drm/i915/perf: Initialise dynamic sysfs group before creation Chris Wilson
2017-08-09 14:57 ` Lionel Landwerlin
2017-08-09 15:02 ` Chris Wilson
2017-08-09 15:14 ` Lionel Landwerlin [this message]
2017-08-09 15:20 ` Lionel Landwerlin
2017-08-09 15:22 ` ✗ Fi.CI.BAT: warning for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65d93b16-e9d1-53bb-5a49-fa6e48b87584@intel.com \
--to=lionel.g.landwerlin@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.