From: Jan Beulich <jbeulich@suse.com>
To: "Roger Pau Monné" <roger.pau@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Christopher Clark <christopher.w.clark@gmail.com>
Subject: Re: [PATCH] argo: don't leak stack contents when returning ring info
Date: Thu, 14 Jan 2021 18:01:40 +0100 [thread overview]
Message-ID: <65e8b764-7ace-9562-89ae-e0259e98835d@suse.com> (raw)
In-Reply-To: <20210114165914.rtnzuf5qolifcxv4@Air-de-Roger>
On 14.01.2021 17:59, Roger Pau Monné wrote:
> On Thu, Jan 14, 2021 at 03:01:06PM +0100, Jan Beulich wrote:
>> The max_message_size field of the output gets filled only when the flags
>> field is non-zero. Don't copy back uninitialized data to guest context.
>
> I'm afraid I'm missing something. AFAICT ent gets filled from the
> user-space contents of data_ent_hnd that's copied from user-space at
> the top of the function,
Oh, I managed to overlook this multiple time, so ...
> so there's no leak from hypervisor stack in
> the return path?
... yes indeed. Withdrawing the patch.
Thanks for noticing,
Jan
prev parent reply other threads:[~2021-01-14 17:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 14:01 [PATCH] argo: don't leak stack contents when returning ring info Jan Beulich
2021-01-14 16:59 ` Roger Pau Monné
2021-01-14 17:01 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65e8b764-7ace-9562-89ae-e0259e98835d@suse.com \
--to=jbeulich@suse.com \
--cc=christopher.w.clark@gmail.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.