From: Ping-Ke Shih <pkshih@realtek.com>
To: Chelsy Ratnawat <chelsyratnawat2001@gmail.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [PATCH] wifi: rtlwifi: remove dead mimo_ps handling from rate update code
Date: Mon, 17 Aug 2026 03:07:44 +0000 [thread overview]
Message-ID: <66136fec9d9044e2945dd8877ad3bfe9@realtek.com> (raw)
In-Reply-To: <20260814165556.1102547-1-chelsy.ratnawat1@ibm.com>
Chelsy Ratnawat <chelsyratnawat2001@gmail.com> wrote:
> From: Chelsy Ratnawat <chelsyratnawat2001@gmail.com>
>
> Several rtlwifi drivers declare mimo_ps as IEEE80211_SMPS_OFF
> and never modify it. As a result, conditionals checking for
> IEEE80211_SMPS_STATIC or IEEE80211_SMPS_DYNAMIC are false,
> making those branches unreachable.
>
> Remove the unused mimo_ps variables, drop the dead SMPS
> branches, and simplify the remaining rate mask selection logic
> without changing runtime behavior. Also move ratr_mask
> declarations out of the removed conditional blocks where
> appropriate.
>
> Signed-off-by: Chelsy Ratnawat <chelsyratnawat2001@gmail.com>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
By the way, I think this is v2, right? You should mention this in subject
and add change log here with '---' delimiter.
But no need resend because of this.
next prev parent reply other threads:[~2026-08-17 3:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-14 16:55 [PATCH] wifi: rtlwifi: remove dead mimo_ps handling from rate update code Chelsy Ratnawat
2026-08-17 3:07 ` Ping-Ke Shih [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-08-05 8:20 Chelsy Ratnawat
2026-08-10 3:06 ` Ping-Ke Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66136fec9d9044e2945dd8877ad3bfe9@realtek.com \
--to=pkshih@realtek.com \
--cc=chelsyratnawat2001@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.