From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v1] examples/ethtool: fix segfault querying non-PCI devices Date: Tue, 20 Dec 2016 16:11:58 +0100 Message-ID: <6618631.VEimddGDOM@xps13> References: <1480474049-3828-1-git-send-email-remy.horton@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Remy Horton Return-path: Received: from mail-wj0-f169.google.com (mail-wj0-f169.google.com [209.85.210.169]) by dpdk.org (Postfix) with ESMTP id B84F1FB9B for ; Tue, 20 Dec 2016 16:12:00 +0100 (CET) Received: by mail-wj0-f169.google.com with SMTP id xy5so178315396wjc.0 for ; Tue, 20 Dec 2016 07:12:00 -0800 (PST) In-Reply-To: <1480474049-3828-1-git-send-email-remy.horton@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-11-30 10:47, Remy Horton: > Doing a device information query on a non-PCI device such as > vhost was resulting in the dereferencing of a NULL pointer > (the absent PCI data), causing a segmentation fault. > > Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample application") > > Signed-off-by: Remy Horton [...] > --- a/doc/guides/rel_notes/release_17_02.rst > +++ b/doc/guides/rel_notes/release_17_02.rst > @@ -70,6 +70,9 @@ Libraries > Examples > ~~~~~~~~ > > + * **examples/ethtool Fixed crash with non-PCI devices.** > + Querying a non-PCI device was dereferencing non-existent PCI data > + resulting in a segmentation fault. indentation fixed here Applied, thanks