From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CBEE3174E6 for ; Fri, 25 Aug 2023 22:55:13 +0000 (UTC) Received: from out-247.mta1.migadu.com (out-247.mta1.migadu.com [IPv6:2001:41d0:203:375::f7]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DAAFB1BEB for ; Fri, 25 Aug 2023 15:55:11 -0700 (PDT) Message-ID: <66320dd7-5da2-992b-ff96-cfee867615bc@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1693004110; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Eqgz55yC3Ox9rsNGpTo7gGmAnoAnUiVAR5Dr9SWA6SI=; b=I5vJzYTgEeV/uWZGT8qhSTKIp2CqkUMYQotoqWSMVOJBMoC9DhguaTfso2vmcDOFgjAXkg akL9cM8ZMdsp39cWZK9vQdqyEWV41VzEaBR6SCcmDiaCtFK54W3y2aJNt5tHY3EcOHo1o3 7NxMrQijtT/Sg9lYrpzqSy7jIr914to= Date: Fri, 25 Aug 2023 15:55:05 -0700 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Reply-To: yonghong.song@linux.dev Subject: Re: [PATCH 4/6] bpf: task_group_seq_get_next: kill next_task Content-Language: en-US To: Oleg Nesterov , Andrew Morton , Yonghong Song Cc: "Eric W. Biederman" , Linus Torvalds , Daniel Borkmann , Kui-Feng Lee , Andrii Nakryiko , Martin KaFai Lau , bpf@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230825161951.GA16878@redhat.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yonghong Song In-Reply-To: <20230825161951.GA16878@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On 8/25/23 9:19 AM, Oleg Nesterov wrote: > It only adds the unnecessary confusion and compicates the "retry" code. > > Signed-off-by: Oleg Nesterov Acked-by: Yonghong Song