Re: [PATCH v14] ath10k: add LED and GPIO controlling support for various chipsets

[Christian Marangi <ansuelsmth@gmail.com>]

On Fri, May 10, 2024 at 04:50:52PM +0300, Kalle Valo wrote:
> Christian Marangi <ansuelsmth@gmail.com> writes:
> 
> >> 
> >> Sorry for the delay but finally I looked at this again. I decided to
> >> just remove the fixme and otherwise it looks good for me. Please check
> >> my changes:
> >> 
> >> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=688130a66ed49f20ca0ce02c3987f6a474f7c93a
> >>
> >
> > All ok for me, Just I notice the ATH10K_LEDS is not exposed anymore? Is
> > that intended?
> 
> Yes. It follows the same idea as other wireless drivers do, for example iwlwifi:
> 
> config IWLWIFI_LEDS
> 	bool
> 	depends on LEDS_CLASS=y || LEDS_CLASS=MAC80211
> 	depends on IWLMVM || IWLDVM
> 	select LEDS_TRIGGERS
> 	select MAC80211_LEDS
> 	default y
> 
> So what this patch now does:
> 
> config ATH10K_LEDS
> 	bool
> 	depends on ATH10K
> 	depends on LEDS_CLASS=y || LEDS_CLASS=MAC80211
> 	default y
> 
> The idea being that if LEDS_CLASS is enabled then ATH10K_LEDS is
> automatically enabled. But please let us know if something is wrong
> here.
>

Sure, was just asking some clarification about it. Not a problem for me
since we are using other pattern to handle this.

-- 
	Ansuel