* [PATCH] PENDING: Bluetooth: Increase settling time for baudrate change VSC
@ 2024-06-03 12:53 Janaki Ramaiah Thota
2024-06-03 12:53 ` [PATCH v1] Bluetooth: hci_qca: " Janaki Ramaiah Thota
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Janaki Ramaiah Thota @ 2024-06-03 12:53 UTC (permalink / raw)
To: Marcel Holtmann, Luiz Augusto von Dentz
Cc: quic_mohamull, quic_hbandi, linux-bluetooth, linux-kernel
From: Harish Bandi <quic_hbandi@quicinc.com>
This change is done to align the settling time and
synchronization for baudrate VSC for WCN6750.
In logging disabled builds and few devices
baudrate change and flow control is taking time
so increasing the wait time to controller and uart
to handle baudrate change request properly.
Change-Id: If0631cb886e53817f963f075e626c89a791b7be4
Signed-off-by: Harish Bandi <quic_hbandi@quicinc.com>
---
diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
index eba9165..a59b35e 100644
--- a/drivers/bluetooth/btqca.c
+++ b/drivers/bluetooth/btqca.c
@@ -600,7 +600,6 @@
rom_ver = ((soc_ver & 0x00000f00) >> 0x04) | (soc_ver & 0x0000000f);
if (soc_type == QCA_WCN6750) {
- msleep(100);
qca_send_patch_config_cmd(hdev);
}
diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
index d8abd27..0b41214 100644
--- a/drivers/bluetooth/hci_qca.c
+++ b/drivers/bluetooth/hci_qca.c
@@ -1356,11 +1356,13 @@
case QCA_WCN3990:
case QCA_WCN3991:
case QCA_WCN3998:
- case QCA_WCN6750:
case QCA_WCN6855:
case QCA_WCN7850:
usleep_range(1000, 10000);
break;
+ case QCA_WCN6750:
+ msleep(30);
+ break;
default:
msleep(300);
@@ -1904,7 +1906,6 @@
qca_set_speed(hu, QCA_INIT_SPEED);
}
- usleep_range(1000, 20000);
/* Setup user speed if needed */
speed = qca_get_speed(hu, QCA_OPER_SPEED);
if (speed) {
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v1] Bluetooth: hci_qca: Increase settling time for baudrate change VSC
2024-06-03 12:53 [PATCH] PENDING: Bluetooth: Increase settling time for baudrate change VSC Janaki Ramaiah Thota
@ 2024-06-03 12:53 ` Janaki Ramaiah Thota
2024-06-03 13:24 ` [v1] " bluez.test.bot
2024-06-03 13:05 ` PENDING: Bluetooth: " bluez.test.bot
[not found] ` <SA1PR02MB8694BA5D75CF5FF8C86C7274E1FF2@SA1PR02MB8694.namprd02.prod.outlook.com>
2 siblings, 1 reply; 6+ messages in thread
From: Janaki Ramaiah Thota @ 2024-06-03 12:53 UTC (permalink / raw)
To: Marcel Holtmann, Luiz Augusto von Dentz
Cc: quic_mohamull, quic_hbandi, linux-bluetooth, linux-kernel
This change is done to align the settling time and
synchronization for baudrate VSC for WCN6750.
In logging disabled builds and few devices
baudrate change and flow control is taking time
so increasing the wait time to controller and uart
to handle baudrate change request properly.
Signed-off-by: Janaki Ramaiah Thota <quic_janathot@quicinc.com>
---
drivers/bluetooth/hci_qca.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
index 0c9c9ee56592..667687835306 100644
--- a/drivers/bluetooth/hci_qca.c
+++ b/drivers/bluetooth/hci_qca.c
@@ -1356,12 +1356,15 @@ static int qca_set_baudrate(struct hci_dev *hdev, uint8_t baudrate)
case QCA_WCN3990:
case QCA_WCN3991:
case QCA_WCN3998:
- case QCA_WCN6750:
case QCA_WCN6855:
case QCA_WCN7850:
usleep_range(1000, 10000);
break;
+ case QCA_WCN6750:
+ msleep(30);
+ break;
+
default:
msleep(300);
}
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 6+ messages in thread* RE: [v1] Bluetooth: hci_qca: Increase settling time for baudrate change VSC
2024-06-03 12:53 ` [PATCH v1] Bluetooth: hci_qca: " Janaki Ramaiah Thota
@ 2024-06-03 13:24 ` bluez.test.bot
0 siblings, 0 replies; 6+ messages in thread
From: bluez.test.bot @ 2024-06-03 13:24 UTC (permalink / raw)
To: linux-bluetooth, quic_janathot
[-- Attachment #1: Type: text/plain, Size: 2481 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=858290
---Test result---
Test Summary:
CheckPatch PASS 0.70 seconds
GitLint PASS 0.34 seconds
SubjectPrefix PASS 0.14 seconds
BuildKernel PASS 29.93 seconds
CheckAllWarning PASS 32.48 seconds
CheckSparse PASS 37.91 seconds
CheckSmatch FAIL 36.07 seconds
BuildKernel32 PASS 28.59 seconds
TestRunnerSetup PASS 520.82 seconds
TestRunner_l2cap-tester PASS 20.30 seconds
TestRunner_iso-tester PASS 30.07 seconds
TestRunner_bnep-tester PASS 4.80 seconds
TestRunner_mgmt-tester PASS 111.73 seconds
TestRunner_rfcomm-tester PASS 7.35 seconds
TestRunner_sco-tester PASS 14.95 seconds
TestRunner_ioctl-tester PASS 7.83 seconds
TestRunner_mesh-tester PASS 5.88 seconds
TestRunner_smp-tester PASS 6.86 seconds
TestRunner_userchan-tester PASS 5.05 seconds
IncrementalBuild PASS 27.70 seconds
Details
##############################
Test: CheckSmatch - FAIL
Desc: Run smatch tool with source
Output:
Segmentation fault (core dumped)
make[4]: *** [scripts/Makefile.build:244: net/bluetooth/hci_core.o] Error 139
make[4]: *** Deleting file 'net/bluetooth/hci_core.o'
make[3]: *** [scripts/Makefile.build:485: net/bluetooth] Error 2
make[2]: *** [scripts/Makefile.build:485: net] Error 2
make[2]: *** Waiting for unfinished jobs....
Segmentation fault (core dumped)
make[4]: *** [scripts/Makefile.build:244: drivers/bluetooth/bcm203x.o] Error 139
make[4]: *** Deleting file 'drivers/bluetooth/bcm203x.o'
make[4]: *** Waiting for unfinished jobs....
Segmentation fault (core dumped)
make[4]: *** [scripts/Makefile.build:244: drivers/bluetooth/bpa10x.o] Error 139
make[4]: *** Deleting file 'drivers/bluetooth/bpa10x.o'
make[3]: *** [scripts/Makefile.build:485: drivers/bluetooth] Error 2
make[2]: *** [scripts/Makefile.build:485: drivers] Error 2
make[1]: *** [/github/workspace/src/src/Makefile:1919: .] Error 2
make: *** [Makefile:240: __sub-make] Error 2
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: PENDING: Bluetooth: Increase settling time for baudrate change VSC
2024-06-03 12:53 [PATCH] PENDING: Bluetooth: Increase settling time for baudrate change VSC Janaki Ramaiah Thota
2024-06-03 12:53 ` [PATCH v1] Bluetooth: hci_qca: " Janaki Ramaiah Thota
@ 2024-06-03 13:05 ` bluez.test.bot
[not found] ` <SA1PR02MB8694BA5D75CF5FF8C86C7274E1FF2@SA1PR02MB8694.namprd02.prod.outlook.com>
2 siblings, 0 replies; 6+ messages in thread
From: bluez.test.bot @ 2024-06-03 13:05 UTC (permalink / raw)
To: linux-bluetooth, quic_janathot
[-- Attachment #1: Type: text/plain, Size: 663 bytes --]
This is an automated email and please do not reply to this email.
Dear Submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
While preparing the CI tests, the patches you submitted couldn't be applied to the current HEAD of the repository.
----- Output -----
error: patch failed: drivers/bluetooth/btqca.c:600
error: drivers/bluetooth/btqca.c: patch does not apply
error: patch failed: drivers/bluetooth/hci_qca.c:1904
error: drivers/bluetooth/hci_qca.c: patch does not apply
hint: Use 'git am --show-current-patch' to see the failed patch
Please resolve the issue and submit the patches again.
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 6+ messages in thread[parent not found: <SA1PR02MB8694BA5D75CF5FF8C86C7274E1FF2@SA1PR02MB8694.namprd02.prod.outlook.com>]
* Re: FW: [PATCH] PENDING: Bluetooth: Increase settling time for baudrate change VSC
[not found] ` <SA1PR02MB8694BA5D75CF5FF8C86C7274E1FF2@SA1PR02MB8694.namprd02.prod.outlook.com>
@ 2024-06-03 13:47 ` Janaki Ramaiah Thota
0 siblings, 0 replies; 6+ messages in thread
From: Janaki Ramaiah Thota @ 2024-06-03 13:47 UTC (permalink / raw)
To: Marcel Holtmann, Luiz Augusto von Dentz
Cc: linux-bluetooth, linux-kernel, quic_hbandi, quic_mohamull
> From: Janaki Ramaiah Thota (Temp) (QUIC) <quic_janathot@quicinc.com>
> Sent: Monday, June 3, 2024 6:24 PM
> To: Marcel Holtmann <marcel@holtmann.org>; Luiz Augusto von Dentz <luiz.dentz@gmail.com>
> Cc: Mohammed Sameer Mulla (QUIC) <quic_mohamull@quicinc.com>; Harish Bandi (QUIC) <quic_hbandi@quicinc.com>; linux-bluetooth@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] PENDING: Bluetooth: Increase settling time for baudrate change VSC
>
> From: Harish Bandi <quic_hbandi@quicinc.com>
>
> This change is done to align the settling time and synchronization for baudrate VSC for WCN6750.
>
> In logging disabled builds and few devices baudrate change and flow control is taking time so increasing the wait time to controller and uart to handle baudrate change request properly.
>
> Change-Id: If0631cb886e53817f963f075e626c89a791b7be4
> Signed-off-by: Harish Bandi <quic_hbandi@quicinc.com>
> ---
>
> diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c index eba9165..a59b35e 100644
> --- a/drivers/bluetooth/btqca.c
> +++ b/drivers/bluetooth/btqca.c
> @@ -600,7 +600,6 @@
> rom_ver = ((soc_ver & 0x00000f00) >> 0x04) | (soc_ver & 0x0000000f);
>
> if (soc_type == QCA_WCN6750) {
> - msleep(100);
> qca_send_patch_config_cmd(hdev);
> }
>
> diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c index d8abd27..0b41214 100644
> --- a/drivers/bluetooth/hci_qca.c
> +++ b/drivers/bluetooth/hci_qca.c
> @@ -1356,11 +1356,13 @@
> case QCA_WCN3990:
> case QCA_WCN3991:
> case QCA_WCN3998:
> - case QCA_WCN6750:
> case QCA_WCN6855:
> case QCA_WCN7850:
> usleep_range(1000, 10000);
> break;
> + case QCA_WCN6750:
> + msleep(30);
> + break;
>
> default:
> msleep(300);
> @@ -1904,7 +1906,6 @@
> qca_set_speed(hu, QCA_INIT_SPEED);
> }
>
> - usleep_range(1000, 20000);
> /* Setup user speed if needed */
> speed = qca_get_speed(hu, QCA_OPER_SPEED);
> if (speed) {
Please ignore the above patch.
-Janaki Ram
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v1] Bluetooth: hci_qca: Increase settling time for baudrate change VSC
@ 2024-06-17 7:00 Janaki Ramaiah Thota
2024-06-17 7:35 ` [v1] " bluez.test.bot
0 siblings, 1 reply; 6+ messages in thread
From: Janaki Ramaiah Thota @ 2024-06-17 7:00 UTC (permalink / raw)
To: Marcel Holtmann, Luiz Augusto von Dentz
Cc: quic_mohamull, quic_hbandi, linux-bluetooth, linux-kernel
This change is done to align the settling time and
synchronization for baudrate VSC for WCN6750.
In logging disabled builds and few devices
baudrate change and flow control is taking time
so increasing the wait time to controller and uart
to handle baudrate change request properly.
Signed-off-by: Janaki Ramaiah Thota <quic_janathot@quicinc.com>
---
drivers/bluetooth/hci_qca.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
index 0c9c9ee56592..667687835306 100644
--- a/drivers/bluetooth/hci_qca.c
+++ b/drivers/bluetooth/hci_qca.c
@@ -1356,12 +1356,15 @@ static int qca_set_baudrate(struct hci_dev *hdev, uint8_t baudrate)
case QCA_WCN3990:
case QCA_WCN3991:
case QCA_WCN3998:
- case QCA_WCN6750:
case QCA_WCN6855:
case QCA_WCN7850:
usleep_range(1000, 10000);
break;
+ case QCA_WCN6750:
+ msleep(30);
+ break;
+
default:
msleep(300);
}
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [v1] Bluetooth: hci_qca: Increase settling time for baudrate change VSC
2024-06-17 7:00 [PATCH v1] Bluetooth: hci_qca: " Janaki Ramaiah Thota
@ 2024-06-17 7:35 ` bluez.test.bot
0 siblings, 0 replies; 6+ messages in thread
From: bluez.test.bot @ 2024-06-17 7:35 UTC (permalink / raw)
To: linux-bluetooth, quic_janathot
[-- Attachment #1: Type: text/plain, Size: 2043 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=862483
---Test result---
Test Summary:
CheckPatch PASS 0.63 seconds
GitLint PASS 0.52 seconds
SubjectPrefix PASS 0.11 seconds
BuildKernel PASS 31.03 seconds
CheckAllWarning PASS 33.56 seconds
CheckSparse PASS 39.37 seconds
CheckSmatch PASS 105.21 seconds
BuildKernel32 PASS 29.79 seconds
TestRunnerSetup PASS 535.16 seconds
TestRunner_l2cap-tester PASS 20.70 seconds
TestRunner_iso-tester FAIL 39.66 seconds
TestRunner_bnep-tester PASS 5.05 seconds
TestRunner_mgmt-tester FAIL 115.36 seconds
TestRunner_rfcomm-tester PASS 7.77 seconds
TestRunner_sco-tester PASS 15.31 seconds
TestRunner_ioctl-tester PASS 8.16 seconds
TestRunner_mesh-tester PASS 6.14 seconds
TestRunner_smp-tester PASS 7.17 seconds
TestRunner_userchan-tester PASS 5.40 seconds
IncrementalBuild PASS 29.33 seconds
Details
##############################
Test: TestRunner_iso-tester - FAIL
Desc: Run iso-tester with test-runner
Output:
Total: 122, Passed: 117 (95.9%), Failed: 1, Not Run: 4
Failed Test Cases
ISO Connect2 Suspend - Success Failed 6.165 seconds
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner
Output:
Total: 492, Passed: 488 (99.2%), Failed: 2, Not Run: 2
Failed Test Cases
LL Privacy - Add Device 4 (2 Devices to AL) Failed 0.171 seconds
LL Privacy - Add Device 7 (AL is full) Failed 0.206 seconds
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-06-17 7:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-03 12:53 [PATCH] PENDING: Bluetooth: Increase settling time for baudrate change VSC Janaki Ramaiah Thota
2024-06-03 12:53 ` [PATCH v1] Bluetooth: hci_qca: " Janaki Ramaiah Thota
2024-06-03 13:24 ` [v1] " bluez.test.bot
2024-06-03 13:05 ` PENDING: Bluetooth: " bluez.test.bot
[not found] ` <SA1PR02MB8694BA5D75CF5FF8C86C7274E1FF2@SA1PR02MB8694.namprd02.prod.outlook.com>
2024-06-03 13:47 ` FW: [PATCH] " Janaki Ramaiah Thota
-- strict thread matches above, loose matches on Subject: below --
2024-06-17 7:00 [PATCH v1] Bluetooth: hci_qca: " Janaki Ramaiah Thota
2024-06-17 7:35 ` [v1] " bluez.test.bot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.