From: David Howells <dhowells@redhat.com>
To: Corcodel Marian <asd@marian1000.go.ro>
Cc: dhowells@redhat.com, linux-cachefs@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [Linux-cachefs] Variable fscache_cache_cleared_wq undefined!
Date: Thu, 06 Apr 2017 15:03:42 +0100 [thread overview]
Message-ID: <6663.1491487422@warthog.procyon.org.uk> (raw)
In-Reply-To: <afedd41c-8445-af8d-3ea5-841f8c557e58@marian1000.go.ro>
Corcodel Marian <asd@marian1000.go.ro> wrote:
> Hi on function fscache_object_destroyed may run with variable undefined when
> in not set CONFIG_FSCACHE
>
> +void fscache_object_destroyed(struct fscache_cache *cache)
> +{
> +#ifdef CONFIG_FSCACHE
> + if (atomic_dec_and_test(&cache->object_count))
> + wake_up_all(&fscache_cache_cleared_wq);
> +#endif
> }
No one should be including linux/fscache-cache.h from code that's built when
CONFIG_FSCACHE is disabled.
David
parent reply other threads:[~2017-04-06 14:04 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <afedd41c-8445-af8d-3ea5-841f8c557e58@marian1000.go.ro>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6663.1491487422@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=asd@marian1000.go.ro \
--cc=linux-cachefs@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.