From: Tobias Wolf <t.wolf@vplace.de>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: linux-mips@linux-mips.org
Subject: [PATCH 2/2 v2] of: Add check to of_scan_flat_dt() before accessing initial_boot_params
Date: Wed, 23 Nov 2016 07:11:23 +0100 [thread overview]
Message-ID: <6667110.cBpoIbUc5V@loki> (raw)
In-Reply-To: <a13d095d-cdc9-8deb-82e2-f19b15748a4a@cogentembedded.com>
An empty __dtb_start to __dtb_end section might result in initial_boot_params
being null for arch/mips/ralink. This showed that the boot process hangs
indefinitely in of_scan_flat_dt().
Signed-off-by: Tobias Wolf <dev-NTEO@vplace.de>
---
--- a/drivers/of/fdt.c
+++ b/drivers/of/fdt.c
@@ -628,6 +628,9 @@
void *data),
void *data)
{
+ if (!initial_boot_params)
+ return 0;
+
const void *blob = initial_boot_params;
const char *pathp;
int offset, rc = 0, depth = -1;
---
Dear Sergei,
After checking the use of "of_scan_flat_dt()" I revised the patch to return 0
as any other value would most likely break code in:
Best regards
Tobias
next prev parent reply other threads:[~2016-11-23 6:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <3700342.djbc9u0nWG@loki>
2016-11-21 16:22 ` [PATCH 1/2] ralink: Introduce fw_passed_dtb to arch/mips/ralink Tobias Wolf
[not found] ` <2966402.rBqcQZDeOh@loki>
2016-11-21 16:23 ` [PATCH 2/2] of: Add check to of_scan_flat_dt() before accessing initial_boot_params Tobias Wolf
2016-11-21 17:21 ` Sergei Shtylyov
2016-11-21 17:35 ` Tobias Wolf
2016-11-23 6:11 ` Tobias Wolf [this message]
2016-11-23 8:47 ` [PATCH 2/2 v2] " Sergei Shtylyov
2016-11-23 9:40 ` [PATCH 2/2 v3] " Tobias Wolf
2016-12-13 10:46 ` [PATCH 1/2 v2] ralink: Introduce fw_passed_dtb to arch/mips/ralink Tobias Wolf
2016-12-13 22:40 ` John Crispin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6667110.cBpoIbUc5V@loki \
--to=t.wolf@vplace.de \
--cc=linux-mips@linux-mips.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.