All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Marangi <ansuelsmth@gmail.com>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: "Hauke Mehrtens" <hauke@hauke-m.de>,
	"Rafał Miłecki" <zajec5@gmail.com>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Florian Fainelli" <florian.fainelli@broadcom.com>,
	"Broadcom internal kernel review list"
	<bcm-kernel-feedback-list@broadcom.com>,
	"Álvaro Fernández Rojas" <noltari@gmail.com>,
	linux-mips@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 1/5] mips: bmips: BCM6358: make sure CBR is correctly set
Date: Tue, 11 Jun 2024 15:04:36 +0200	[thread overview]
Message-ID: <6668503a.050a0220.9ec4a.4777@mx.google.com> (raw)
In-Reply-To: <ZmhHw5QZCQ6G6EbK@alpha.franken.de>

On Tue, Jun 11, 2024 at 02:49:07PM +0200, Thomas Bogendoerfer wrote:
> On Tue, Jun 11, 2024 at 01:35:33PM +0200, Christian Marangi wrote:
> > It was discovered that some device have CBR address set to 0 causing
> > kernel panic when arch_sync_dma_for_cpu_all is called.
> > 
> > This was notice in situation where the system is booted from TP1 and
> > BMIPS_GET_CBR() returns 0 instead of a valid address and
> > !!(read_c0_brcm_cmt_local() & (1 << 31)); not failing.
> > 
> > The current check whether RAC flush should be disabled or not are not
> > enough hence lets check if CBR is a valid address or not.
> > 
> > Fixes: ab327f8acdf8 ("mips: bmips: BCM6358: disable RAC flush for TP1")
> 
> should I apply it to mips-fixes ? If not could you just ammend
> it with the following patch, where this is changed again ?
>

Ideally this should be backported to stable kernel since it does cause
kernel panic. This is why it's split and it's the first patch of the
series.

-- 
	Ansuel

  reply	other threads:[~2024-06-11 13:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-11 11:35 [PATCH v7 0/5] mips: bmips: improve handling of RAC and CBR addr Christian Marangi
2024-06-11 11:35 ` [PATCH v7 1/5] mips: bmips: BCM6358: make sure CBR is correctly set Christian Marangi
2024-06-11 12:49   ` Thomas Bogendoerfer
2024-06-11 13:04     ` Christian Marangi [this message]
2024-06-11 14:03       ` Thomas Bogendoerfer
2024-06-11 14:12   ` Thomas Bogendoerfer
2024-06-11 11:35 ` [PATCH v7 2/5] mips: bmips: rework and cache CBR addr handling Christian Marangi
2024-06-20 14:40   ` Thomas Bogendoerfer
2024-06-20 15:28     ` Christian Marangi
2024-06-11 11:35 ` [PATCH v7 3/5] dt-bindings: mips: brcm: Document brcm,bmips-cbr-reg property Christian Marangi
2024-06-11 11:35 ` [PATCH v7 4/5] mips: bmips: setup: make CBR address configurable Christian Marangi
2024-06-11 11:35 ` [PATCH v7 5/5] mips: bmips: enable RAC on BMIPS4350 Christian Marangi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6668503a.050a0220.9ec4a.4777@mx.google.com \
    --to=ansuelsmth@gmail.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=florian.fainelli@broadcom.com \
    --cc=hauke@hauke-m.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=noltari@gmail.com \
    --cc=robh@kernel.org \
    --cc=tsbogend@alpha.franken.de \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.