From: Baolu Lu <baolu.lu@linux.intel.com>
To: Jason Gunthorpe <jgg@ziepe.ca>, "Tian, Kevin" <kevin.tian@intel.com>
Cc: baolu.lu@linux.intel.com, Xu Yilun <yilun.xu@linux.intel.com>,
"Aneesh Kumar K . V" <aneesh.kumar@kernel.org>,
"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
"x86@kernel.org" <x86@kernel.org>,
"linux-coco@lists.linux.dev" <linux-coco@lists.linux.dev>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
Kiryl Shutsemau <kas@kernel.org>,
"Edgecombe, Rick P" <rick.p.edgecombe@intel.com>,
"Li, Xiaoyao" <xiaoyao.li@intel.com>,
"Gao, Chao" <chao.gao@intel.com>,
Binbin Wu <binbin.wu@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 4/4] coco/tdx-host: Initialize trusted DMA on all capable IOMMUs
Date: Mon, 19 Oct 2026 16:16:07 +0800 [thread overview]
Message-ID: <666e6f72-eea0-4a1b-919a-9187a52cbe1c@linux.intel.com> (raw)
In-Reply-To: <20261016145830.GA448730@ziepe.ca>
On 10/16/2026 10:58 PM, Jason Gunthorpe wrote:
>>> - The TDX Connect architecture places requirements on the host
>>> iommu driver while the secure IOMMU is being set up. For example,
>>> the host iommu driver must block the enhanced command (ECMD)
>>> interface while the TDH.IOMMU.SETUP SEAMCALL runs, and it must
>>> reserve the upper half of the domain ID space. These steps have
>>> to happen atomically under the iommu driver's own locks. As a
>>> result, the Intel iommu driver needs to merge the two steps above
>>> into one.
>> Didn't get this. Both ECMD and DID reservation are TDX specific things.
>> How are they related to the two steps in the ARM sides and why calls
>> for merging?
>>
>> and why are they must be done atomically? they are conditions to
>> execute TDH.IOMMU.SETUP, but it is perfectly fine to reserve DID
>> at an early point then block ECMD later...
> That's going to be a bit of a PITA, since the DIDs can be in use when
> the tdx module is start potentially.
>
> I suppose you can start out by just failing if this has happened.
>
> But as soon as reasonably possible once the system opts into a TDX
> operation the VT-d drivers should stop using the upper did space.
>
> Otherwise you will have to implement live DID renaming, which is a
> PITA in an iommu driver.
Yes, agreed.
Thanks,
baolu
next prev parent reply other threads:[~2026-10-19 8:16 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 1:07 [PATCH v2 0/4] coco/tdx-host: Introduce trusted DMA initialization support Lu Baolu
2026-10-15 1:07 ` [PATCH v2 1/4] x86/virt/tdx: Add SEAMCALL wrappers for IOMMU setup/clear Lu Baolu
2026-10-15 1:28 ` sashiko-bot
2026-10-15 5:36 ` Baolu Lu
2026-10-15 6:34 ` Xu Yilun
2026-10-15 1:07 ` [PATCH v2 2/4] x86/virt/tdx: Read global metadata for trusted IOMMU Lu Baolu
2026-10-15 6:47 ` Xu Yilun
2026-10-16 7:59 ` Tian, Kevin
2026-10-15 1:07 ` [PATCH v2 3/4] iommu/vt-d: Add an API for tdx-host when enabling trusted DMA Lu Baolu
2026-10-15 1:07 ` [PATCH v2 4/4] coco/tdx-host: Initialize trusted DMA on all capable IOMMUs Lu Baolu
2026-10-15 1:31 ` sashiko-bot
2026-10-15 5:58 ` Baolu Lu
2026-10-15 8:31 ` Xu Yilun
2026-10-15 17:37 ` Jason Gunthorpe
2026-10-16 7:03 ` Baolu Lu
2026-10-16 7:17 ` Tian, Kevin
2026-10-16 14:58 ` Jason Gunthorpe
2026-10-19 8:16 ` Baolu Lu [this message]
2026-10-19 8:12 ` Baolu Lu
2026-10-16 14:58 ` Jason Gunthorpe
2026-10-19 8:17 ` Baolu Lu
2026-10-19 7:03 ` Chao Gao
2026-10-19 8:40 ` Baolu Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=666e6f72-eea0-4a1b-919a-9187a52cbe1c@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=aneesh.kumar@kernel.org \
--cc=binbin.wu@linux.intel.com \
--cc=chao.gao@intel.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@ziepe.ca \
--cc=kas@kernel.org \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=rick.p.edgecombe@intel.com \
--cc=x86@kernel.org \
--cc=xiaoyao.li@intel.com \
--cc=yilun.xu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.