From: Jens Axboe <axboe@kernel.dk>
To: Pavel Begunkov <asml.silence@gmail.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2][for-next] cleanup submission path
Date: Sun, 27 Oct 2019 10:32:04 -0600 [thread overview]
Message-ID: <666ed447-ba8f-29e7-237f-de8044aa63ea@kernel.dk> (raw)
In-Reply-To: <cover.1572189860.git.asml.silence@gmail.com>
On 10/27/19 9:35 AM, Pavel Begunkov wrote:
> A small cleanup of very similar but diverged io_submit_sqes() and
> io_ring_submit()
>
> Pavel Begunkov (2):
> io_uring: handle mm_fault outside of submission
> io_uring: merge io_submit_sqes and io_ring_submit
>
> fs/io_uring.c | 116 ++++++++++++++------------------------------------
> 1 file changed, 33 insertions(+), 83 deletions(-)
I like the cleanups here, but one thing that seems off is the
assumption that io_sq_thread() always needs to grab the mm. If
the sqes processed are just READ/WRITE_FIXED, then it never needs
to grab the mm.
--
Jens Axboe
next prev parent reply other threads:[~2019-10-27 16:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-27 15:35 [PATCH 0/2][for-next] cleanup submission path Pavel Begunkov
2019-10-27 15:35 ` [PATCH 1/2] io_uring: handle mm_fault outside of submission Pavel Begunkov
2019-10-27 15:35 ` [PATCH 2/2] io_uring: merge io_submit_sqes and io_ring_submit Pavel Begunkov
2019-10-27 16:32 ` Jens Axboe [this message]
2019-10-27 16:44 ` [PATCH 0/2][for-next] cleanup submission path Pavel Begunkov
2019-10-27 16:49 ` Jens Axboe
2019-10-27 16:56 ` Jens Axboe
2019-10-27 17:19 ` Pavel Begunkov
2019-10-27 17:26 ` Jens Axboe
2019-10-27 17:37 ` Pavel Begunkov
2019-10-27 18:56 ` Pavel Begunkov
2019-10-27 19:02 ` Jens Axboe
2019-10-27 19:17 ` Pavel Begunkov
2019-10-27 19:51 ` Jens Axboe
2019-10-27 19:59 ` Pavel Begunkov
2019-10-28 3:38 ` Jens Axboe
2019-10-28 11:12 ` Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=666ed447-ba8f-29e7-237f-de8044aa63ea@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.