From: Chris Mason <mason@suse.com>
To: Alexander Viro <viro@math.psu.edu>
Cc: David <david@blue-labs.org>, linux-kernel@vger.kernel.org
Subject: Re: [OOPS] report
Date: Fri, 16 Mar 2001 00:51:59 -0500 [thread overview]
Message-ID: <667310000.984721919@tiny> (raw)
In-Reply-To: <Pine.GSO.4.21.0103160030230.10709-100000@weyl.math.psu.edu>
On Friday, March 16, 2001 12:32:56 AM -0500 Alexander Viro
<viro@math.psu.edu> wrote:
>
>
> On Fri, 16 Mar 2001, Chris Mason wrote:
>
>> > ObReiserfs_panic: what the hell is that ->s_lock bit about? panic()
>> > _never_ tries to do any block IO. It looks like a rudiment of something
>> > that hadn't been there for 5 years, if not longer. The same goes for
>> > ext2_panic() and ufs_panic(), BTW... I would suggest crapectomey here.
>>
>> Ugh, that should have been dragged out and shot...patch will come in the
>> AM.
>>
> Unfortunately it's nastier than I thought. panic() does sys_sync(). And
> IMO it really shouldn't. Notice that ->s_lock doesn't prevent
> ->write_inode() and friends from being called.
>
> I suspect that the right fix is to drop the ->s_lock bogosity along with
> sys_sync() call in panic()...
Ok, I was more talking about the ugliness that is reiserfs_panic (how many
times do we need a commented out for(;;)?). For panic() calling sys_sync,
I think there non-filesystem related panics where we do want to sync.
-chris
next prev parent reply other threads:[~2001-03-16 5:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-03-16 2:07 [OOPS] report David
2001-03-16 2:44 ` Alexander Viro
2001-03-16 5:29 ` Chris Mason
2001-03-16 5:32 ` Alexander Viro
2001-03-16 5:51 ` Chris Mason [this message]
2001-03-16 6:03 ` Alexander Viro
2001-03-16 6:27 ` Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=667310000.984721919@tiny \
--to=mason@suse.com \
--cc=david@blue-labs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.