From: Arnd Bergmann <arnd@arndb.de>
To: David Howells <dhowells@redhat.com>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] rxrpc: fix undefined behavior in rxrpc_mark_call_released
Date: Wed, 31 Aug 2016 21:40:02 +0200 [thread overview]
Message-ID: <6677659.qx4okry02K@wuerfel> (raw)
In-Reply-To: <31015.1472665144@warthog.procyon.org.uk>
On Wednesday, August 31, 2016 6:39:04 PM CEST David Howells wrote:
> Arnd Bergmann <arnd@arndb.de> wrote:
>
> > gcc -Wmaybe-initialized correctly points out a newly introduced bug
> > through which we can end up calling rxrpc_queue_call() for a dead
> > connection:
>
> How do you turn that on from within the Kbuild system?
You don't, my mistake. My build bot runs with 6e8d666e9253 ("Disable
"maybe-uninitialized" warning globally") disabled, and I had
assumed that Linus left the warning enabled with "make W=1", but
that was incorrect as Trond Myklebust also pointed out.
You still get the warning with "make EXTRA_CFLAGS=-Wmaybe-uninitialized",
which of course nobody normally does.
I'll try to come up with a patch to enable the warning in the W=1
level in the same conditions that used to be enabled up to v4.7.
Arnd
next prev parent reply other threads:[~2016-08-31 19:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-31 12:39 [PATCH 1/2] NFSv4.1: work around -Wmaybe-uninitialized warning Arnd Bergmann
2016-08-31 12:39 ` Arnd Bergmann
2016-08-31 12:39 ` [PATCH 2/2] rxrpc: fix undefined behavior in rxrpc_mark_call_released Arnd Bergmann
2016-08-31 17:39 ` David Howells
2016-08-31 19:40 ` Arnd Bergmann [this message]
2016-08-31 20:25 ` David Howells
2016-08-31 20:31 ` Arnd Bergmann
2016-08-31 20:52 ` David Miller
2016-08-31 20:26 ` David Howells
2016-08-31 20:37 ` Arnd Bergmann
2016-08-31 21:05 ` David Howells
2016-08-31 13:17 ` [PATCH 1/2] NFSv4.1: work around -Wmaybe-uninitialized warning Trond Myklebust
2016-08-31 13:17 ` Trond Myklebust
2016-08-31 13:37 ` Arnd Bergmann
2016-08-31 13:37 ` Arnd Bergmann
2016-08-31 15:02 ` Trond Myklebust
2016-08-31 15:02 ` Trond Myklebust
2016-08-31 15:02 ` Trond Myklebust
2016-08-31 15:52 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6677659.qx4okry02K@wuerfel \
--to=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.