From: Matteo Martelli <matteomartelli3@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: "Maxime Ripard" <mripard@kernel.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>, "Chen-Yu Tsai" <wens@csie.org>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Samuel Holland" <samuel@sholland.org>,
"Marcus Cooper" <codekipper@gmail.com>,
"Clément Péron" <peron.clem@gmail.com>,
linux-sound@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] ASoC: sunxi: sun4i-i2s: fix LRCLK polarity in i2s mode
Date: Fri, 28 Jun 2024 18:07:12 +0200 [thread overview]
Message-ID: <667edfb08cbf3_eca1e370ea@njaxe.notmuch> (raw)
In-Reply-To: <d614f04e-3609-48e3-bd30-9e57c69cd94d@sirena.org.uk>
Mark Brown wrote:
> On Fri, Jun 07, 2024 at 10:04:43AM +0200, Matteo Martelli wrote:
> > Maxime Ripard wrote:
> > > > - /*
> > > > - * DAI clock polarity
> > > > - *
> > > > - * The setup for LRCK contradicts the datasheet, but under a
> > > > - * scope it's clear that the LRCK polarity is reversed
> > > > - * compared to the expected polarity on the bus.
> > > > - */
> > >
> > > I think we should keep that comment somewhere.
> >
> > I think that keeping that comment would be very misleading since the LRCLK
> > setup would not contradict the datasheet anymore [1][2].
> >
> > Also, do you recall any details about the mentioned scope test setup? Was i2s
> > mode tested in that occasion? It would help clarify the situation.
> >
> > Could anyone verify this patch against H3/H6 SoCs?
>
> Any news on any of this?
Not on my side, unfortunately I cannot test the fix against H3/H6 SoCs.
Matteo Martelli
next prev parent reply other threads:[~2024-06-28 16:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-29 14:00 [PATCH 0/1] ASoC: sunxi: sun4i-i2s: fix LRCLK polarity in i2s mode Matteo Martelli
2024-05-29 14:00 ` Matteo Martelli
2024-05-29 14:00 ` [PATCH 1/1] " Matteo Martelli
2024-05-29 14:00 ` Matteo Martelli
2024-06-06 16:11 ` Maxime Ripard
2024-06-06 16:11 ` Maxime Ripard
2024-06-07 8:04 ` Matteo Martelli
2024-06-07 8:04 ` Matteo Martelli
2024-06-26 19:04 ` Mark Brown
2024-06-28 16:07 ` Matteo Martelli [this message]
2024-07-02 13:42 ` Maxime Ripard
2024-07-02 15:17 ` Matteo Martelli
2024-07-15 14:29 ` Maxime Ripard
2024-07-16 9:27 ` Matteo Martelli
2024-05-29 14:14 ` [PATCH 0/1] " Mark Brown
2024-05-29 14:14 ` Mark Brown
2024-05-29 14:19 ` Matteo Martelli
2024-05-29 14:19 ` Matteo Martelli
2024-05-29 14:23 ` Mark Brown
2024-05-29 14:23 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=667edfb08cbf3_eca1e370ea@njaxe.notmuch \
--to=matteomartelli3@gmail.com \
--cc=broonie@kernel.org \
--cc=codekipper@gmail.com \
--cc=jernej.skrabec@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mripard@kernel.org \
--cc=perex@perex.cz \
--cc=peron.clem@gmail.com \
--cc=samuel@sholland.org \
--cc=tiwai@suse.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.