From: Arnd Bergmann <arnd@arndb.de>
To: outreachy-kernel@googlegroups.com
Cc: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
Subject: Re: [Outreachy kernel] [PATCH v2 1/4] Staging: comedi: Use mutex instead of semaphore in usbduxsigma.c
Date: Fri, 02 Oct 2015 22:52:01 +0200 [thread overview]
Message-ID: <6680937.1mLriPNGFd@wuerfel> (raw)
In-Reply-To: <9a65d840cc57e2ec29bf2dc1ea6269c2e80e6859.1443815181.git.ksenija.stanojevic@gmail.com>
On Friday 02 October 2015 22:04:22 Ksenija Stanojevic wrote:
> Replace binary semaphore with mutex because mutex gives better
> performance.
> This change is safe because the thread that decrements the value of semaphore
> is also the one that increments it, and acts like a mutex where owner of the
> lock is the only one that can release the lock.
>
> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
>
(all four patches)
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Generally speaking however, the subject line is nicer if you put the
driver name in front, to make it easier to distinguish the subject
lines, like:
staging: comedi/usbduxsigma: use mutex instead of semaphore
Greg will let you know if he wants you to respin the patches once
more or if he just takes them as they are.
Arnd
next prev parent reply other threads:[~2015-10-02 20:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-02 20:02 [PATCH v2 0/4] Use mutex insted of semaphore Ksenija Stanojevic
2015-10-02 20:04 ` [PATCH v2 1/4] Staging: comedi: Use mutex instead of semaphore in usbduxsigma.c Ksenija Stanojevic
2015-10-02 20:52 ` Arnd Bergmann [this message]
2015-10-02 20:05 ` [PATCH v2 2/4] Staging: comedi: Use mutex instead of semaphore in usbdux.c Ksenija Stanojevic
2015-10-03 8:11 ` [Outreachy kernel] " Julia Lawall
2015-10-02 20:07 ` [PATCH v2 3/4] Staging: comedi: Use mutex instead of semaphore in usbduxfast.c Ksenija Stanojevic
2015-10-02 20:09 ` [PATCH v2 4/4] Staging: comedi: Use mutex instead of semaphore in ni_usb6501.c Ksenija Stanojevic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6680937.1mLriPNGFd@wuerfel \
--to=arnd@arndb.de \
--cc=ksenija.stanojevic@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.