From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH] drm/i915/dp: Fix intel_edp_compare_alt_mode. Date: Tue, 13 Mar 2018 10:56:03 +0100 Message-ID: <66847faf-dd65-22e9-e5fc-813d528548fc@linux.intel.com> References: <20180313092855.32376-1-maarten.lankhorst@linux.intel.com> <152093404620.515.2548806801533339331@mail.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5F2C36E420 for ; Tue, 13 Mar 2018 09:56:07 +0000 (UTC) In-Reply-To: <152093404620.515.2548806801533339331@mail.alporthouse.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: Paulo Zanoni , Jani Nikula , stable@vger.kernel.org, Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org T3AgMTMtMDMtMTggb20gMTA6NDAgc2NocmVlZiBDaHJpcyBXaWxzb246Cj4gUXVvdGluZyBNYWFy dGVuIExhbmtob3JzdCAoMjAxOC0wMy0xMyAwOToyODo1NSkKPj4gT24gZmktY25sLXkzIHdlIGhh dmUgMiBtb2RlcyB0aGF0IGRpZmZlciBvbmx5IGJ5IGNydGNfY2xvY2suIFRoaXMgbWVhbnMKPj4g dGhhdCBpZiB3ZSByZXF1ZXN0IHRoZSBub3JtYWwgbW9kZSwgd2UgYXV0b21hdGljYWxseSBnZXQg dGhlIGRvd25jbG9ja2VkCj4+IG1vZGUuCj4+Cj4+IFRoaXMgY2FuIGJlIHNlZW4gZHVyaW5nIGJv b3Q6Cj4+IFtkcm06ZHJtX2hlbHBlcl9wcm9iZV9zaW5nbGVfY29ubmVjdG9yX21vZGVzXSBbQ09O TkVDVE9SOjEwMTplRFAtMV0gcHJvYmVkIG1vZGVzIDoKPj4gW2RybTpkcm1fbW9kZV9kZWJ1Z19w cmludG1vZGVsaW5lXSBNb2RlbGluZSAxMDI6IjM4NDB4MjE2MCIgNjAgNTMzMjUwIDM4NDAgMzg4 OCAzOTIwIDQwMDAgMjE2MCAyMTYzIDIxNjggMjIyMiAweDQ4IDB4YQo+PiBbZHJtOmRybV9tb2Rl X2RlYnVnX3ByaW50bW9kZWxpbmVdIE1vZGVsaW5lIDEwMzoiMzg0MHgyMTYwIiA0OCA0MjY2MDAg Mzg0MCAzODg4IDM5MjAgNDAwMCAyMTYwIDIxNjMgMjE2OCAyMjIyIDB4NDAgMHhhCj4+IC4uLgo+ PiBbZHJtOmludGVsX2R1bXBfcGlwZV9jb25maWcgW2k5MTVdXSBbQ1JUQzo1MTpwaXBlIEFdW21v ZGVzZXRdCj4+IFtkcm06aW50ZWxfZHVtcF9waXBlX2NvbmZpZyBbaTkxNV1dIG91dHB1dF90eXBl czogRURQICgweDEwMCkKPj4gW2RybTppbnRlbF9kdW1wX3BpcGVfY29uZmlnIFtpOTE1XV0gY3B1 X3RyYW5zY29kZXI6IEVEUCwgcGlwZSBicHA6IDI0LCBkaXRoZXJpbmc6IDAKPj4gW2RybTppbnRl bF9kdW1wX3BpcGVfY29uZmlnIFtpOTE1XV0gZHAgbV9uOiBsYW5lczogNDsgZ21jaF9tOiA0OTcw MjUwLCBnbWNoX246IDgzODg2MDgsIGxpbmtfbTogODI4Mzc1LCBsaW5rX246IDEwNDg1NzYsIHR1 OiA2NAo+PiBbZHJtOmludGVsX2R1bXBfcGlwZV9jb25maWcgW2k5MTVdXSBkcCBtMl9uMjogbGFu ZXM6IDQ7IGdtY2hfbTogNDk3MDI1MCwgZ21jaF9uOiA4Mzg4NjA4LCBsaW5rX206IDgyODM3NSwg bGlua19uOiAxMDQ4NTc2LCB0dTogNjQKPj4gW2RybTppbnRlbF9kdW1wX3BpcGVfY29uZmlnIFtp OTE1XV0gYXVkaW86IDAsIGluZm9mcmFtZXM6IDAKPj4gW2RybTppbnRlbF9kdW1wX3BpcGVfY29u ZmlnIFtpOTE1XV0gcmVxdWVzdGVkIG1vZGU6Cj4+IFtkcm06ZHJtX21vZGVfZGVidWdfcHJpbnRt b2RlbGluZV0gTW9kZWxpbmUgMDoiMzg0MHgyMTYwIiA2MCA1MzMyNTAgMzg0MCAzODg4IDM5MjAg NDAwMCAyMTYwIDIxNjMgMjE2OCAyMjIyIDB4NDggMHhhCj4+IFtkcm06aW50ZWxfZHVtcF9waXBl X2NvbmZpZyBbaTkxNV1dIGFkanVzdGVkIG1vZGU6Cj4+IFtkcm06ZHJtX21vZGVfZGVidWdfcHJp bnRtb2RlbGluZV0gTW9kZWxpbmUgMDoiMzg0MHgyMTYwIiA0OCA0MjY2MDAgMzg0MCAzODg4IDM5 MjAgNDAwMCAyMTYwIDIxNjMgMjE2OCAyMjIyIDB4NDAgMHhhCj4gQnVnemlsbGE6IGh0dHBzOi8v YnVncy5mcmVlZGVza3RvcC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNTQ2OQo+ID8KClllcywgYWxz bwoKUmVmZXJlbmNlczogaHR0cHM6Ly9idWdzLmZyZWVkZXNrdG9wLm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTA1NDU2CgpTaW5jZSB0aGF0J3MgaG93IEkgZm91bmQgb3V0Li4KCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QK SW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com ([134.134.136.31]:59716 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752464AbeCMJ4I (ORCPT ); Tue, 13 Mar 2018 05:56:08 -0400 Subject: Re: [PATCH] drm/i915/dp: Fix intel_edp_compare_alt_mode. To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: David Weinehall , Rodrigo Vivi , Paulo Zanoni , Jani Nikula , Jim Bride , Joonas Lahtinen , stable@vger.kernel.org References: <20180313092855.32376-1-maarten.lankhorst@linux.intel.com> <152093404620.515.2548806801533339331@mail.alporthouse.com> From: Maarten Lankhorst Message-ID: <66847faf-dd65-22e9-e5fc-813d528548fc@linux.intel.com> Date: Tue, 13 Mar 2018 10:56:03 +0100 MIME-Version: 1.0 In-Reply-To: <152093404620.515.2548806801533339331@mail.alporthouse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: stable-owner@vger.kernel.org List-ID: Op 13-03-18 om 10:40 schreef Chris Wilson: > Quoting Maarten Lankhorst (2018-03-13 09:28:55) >> On fi-cnl-y3 we have 2 modes that differ only by crtc_clock. This means >> that if we request the normal mode, we automatically get the downclocked >> mode. >> >> This can be seen during boot: >> [drm:drm_helper_probe_single_connector_modes] [CONNECTOR:101:eDP-1] probed modes : >> [drm:drm_mode_debug_printmodeline] Modeline 102:"3840x2160" 60 533250 3840 3888 3920 4000 2160 2163 2168 2222 0x48 0xa >> [drm:drm_mode_debug_printmodeline] Modeline 103:"3840x2160" 48 426600 3840 3888 3920 4000 2160 2163 2168 2222 0x40 0xa >> ... >> [drm:intel_dump_pipe_config [i915]] [CRTC:51:pipe A][modeset] >> [drm:intel_dump_pipe_config [i915]] output_types: EDP (0x100) >> [drm:intel_dump_pipe_config [i915]] cpu_transcoder: EDP, pipe bpp: 24, dithering: 0 >> [drm:intel_dump_pipe_config [i915]] dp m_n: lanes: 4; gmch_m: 4970250, gmch_n: 8388608, link_m: 828375, link_n: 1048576, tu: 64 >> [drm:intel_dump_pipe_config [i915]] dp m2_n2: lanes: 4; gmch_m: 4970250, gmch_n: 8388608, link_m: 828375, link_n: 1048576, tu: 64 >> [drm:intel_dump_pipe_config [i915]] audio: 0, infoframes: 0 >> [drm:intel_dump_pipe_config [i915]] requested mode: >> [drm:drm_mode_debug_printmodeline] Modeline 0:"3840x2160" 60 533250 3840 3888 3920 4000 2160 2163 2168 2222 0x48 0xa >> [drm:intel_dump_pipe_config [i915]] adjusted mode: >> [drm:drm_mode_debug_printmodeline] Modeline 0:"3840x2160" 48 426600 3840 3888 3920 4000 2160 2163 2168 2222 0x40 0xa > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105469 > ? Yes, also References: https://bugs.freedesktop.org/show_bug.cgi?id=105456 Since that's how I found out..