From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62511C4361B for ; Fri, 11 Dec 2020 15:43:21 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E6D9423332 for ; Fri, 11 Dec 2020 15:43:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E6D9423332 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 6291316BA; Fri, 11 Dec 2020 16:42:27 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 6291316BA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1607701397; bh=2dYwGCjETUQTTmKyWcFB+ki1hU2IR5mtULF40l1dGqs=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=sD31OGeaO6T3kYmosNQkaZ78hCwQ9ngaqT5cV3qM2YxlAERPOkALgUU7fMXO0H1iR WBoScGWQLqMkw3/wTr1llUfg0/VN7ru+TcV83sBxzf3/f3Nz4pCRJLEiZ1ykfsqUi4 HWpIgFr3dXNn2Y1+C8O8E5U7H6x7ga6K/OL7zc0w= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id BFD51F80105; Fri, 11 Dec 2020 16:42:26 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id E4A37F8020D; Fri, 11 Dec 2020 16:42:24 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 2D2C8F80105 for ; Fri, 11 Dec 2020 16:42:14 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 2D2C8F80105 IronPort-SDR: 9fyfHsOgAuGe71H1u4Cmk2wWXJ8NXWRP1g8ElqpOhg84uzqGrObkWxB14s8LLrFCERPBVbo+88 h6ZmG2dGBRJA== X-IronPort-AV: E=McAfee;i="6000,8403,9832"; a="174595888" X-IronPort-AV: E=Sophos;i="5.78,411,1599548400"; d="scan'208";a="174595888" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Dec 2020 07:42:10 -0800 IronPort-SDR: 8GcczHJRgPBSbn8VAs1UX0mK6shOPulvVbZXGtRkUx2zpw+u2LOGZr/EjJIldtVope8EorfnUR SifaBcA/1b3Q== X-IronPort-AV: E=Sophos;i="5.78,411,1599548400"; d="scan'208";a="349521183" Received: from aslawinx-mobl.ger.corp.intel.com (HELO [10.249.144.44]) ([10.249.144.44]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Dec 2020 07:42:07 -0800 Subject: Re: [PATCH] ASoC: Intel: Skylake: Check the kcontrol against NULL To: Lukasz Majczak , Pierre-Louis Bossart , Liam Girdwood , Mateusz Gorski References: <20201210121438.7718-1-lma@semihalf.com> From: =?UTF-8?Q?Amadeusz_S=c5=82awi=c5=84ski?= Message-ID: <669da93a-2ef2-fa08-6c7f-be2e6b5ac363@linux.intel.com> Date: Fri, 11 Dec 2020 16:42:04 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201210121438.7718-1-lma@semihalf.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: alsa-devel@alsa-project.org, Guenter Roeck , Radoslaw Biernacki , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Marcin Wojtas , Alex Levin X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 12/10/2020 1:14 PM, Lukasz Majczak wrote: > + kcontrol = dobj->control.kcontrol; > + if(!kcontrol) > + continue; Small nitpick, there should be space between if and opening parenthesis as recommended by coding style. Thanks, Amadeusz