RE: [BlueZ,v1] hcitool - Added option for Peripheral Initiated Connection Parameter Update Request.

[bluez.test.bot@gmail.com]

[-- Attachment #1: Type: text/plain, Size: 8292 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=873214

---Test result---

Test Summary:
CheckPatch                    FAIL      0.85 seconds
GitLint                       FAIL      0.51 seconds
BuildEll                      PASS      25.08 seconds
BluezMake                     PASS      1745.47 seconds
MakeCheck                     PASS      13.31 seconds
MakeDistcheck                 PASS      182.30 seconds
CheckValgrind                 PASS      258.59 seconds
CheckSmatch                   PASS      358.44 seconds
bluezmakeextell               PASS      125.23 seconds
IncrementalBuild              PASS      1496.56 seconds
ScanBuild                     WARNING   1018.73 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
[BlueZ,v1] hcitool - Added option for Peripheral Initiated Connection Parameter Update Request.
WARNING:PREFER_LORE_ARCHIVE: Use lore.kernel.org archive links when possible - see https://lore.kernel.org/lists.html
#105: 
https://marc.info/?l=linux-bluetooth&m=139714173525776&w=2

WARNING:LONG_LINE: line length of 125 exceeds 80 columns
#124: FILE: lib/hci.c:1122:
+int hci_send_acl_data(int dd, uint16_t handle, uint8_t dlen, struct signal_hdr *sh, struct signal_payload_hdr *plh, void *pl)

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#127: FILE: lib/hci.c:1125:
+    hci_acl_hdr ha;$

WARNING:LONG_LINE: line length of 83 exceeds 80 columns
#140: FILE: lib/hci.c:1138:
+	printf("\nACL Packet details[handle:%x, length:%d]\n", ha.handle, ha.dlen);

WARNING:LONG_LINE: line length of 94 exceeds 80 columns
#146: FILE: lib/hci.c:1144:
+		printf("\nACL signal command details[length:%d, cid:%d]\n", sh->len, sh->cid);

ERROR:SPACING: space required before the open parenthesis '('
#147: FILE: lib/hci.c:1145:
+		if(sh->len > 0) {

ERROR:SPACING: space required before the open parenthesis '('
#151: FILE: lib/hci.c:1149:
+			if(plh->len > 0) {

WARNING:LONG_LINE: line length of 86 exceeds 80 columns
#167: FILE: lib/hci.c:1165:
+int hci_signal_le_con_param_update_req(int dd, uint16_t handle, uint16_t interval_min,

WARNING:LONG_LINE: line length of 86 exceeds 80 columns
#168: FILE: lib/hci.c:1166:
+                                        uint16_t interval_max, uint16_t slave_latency,

ERROR:CODE_INDENT: code indent should use tabs where possible
#168: FILE: lib/hci.c:1166:
+                                        uint16_t interval_max, uint16_t slave_latency,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#168: FILE: lib/hci.c:1166:
+                                        uint16_t interval_max, uint16_t slave_latency,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#169: FILE: lib/hci.c:1167:
+                                        uint16_t timeout_multiplier)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#169: FILE: lib/hci.c:1167:
+                                        uint16_t timeout_multiplier)$

WARNING:LONG_LINE: line length of 126 exceeds 80 columns
#240: FILE: lib/hci_lib.h:68:
+int hci_send_acl_data(int dd, uint16_t handle, uint8_t dlen, struct signal_hdr *sh, struct signal_payload_hdr *plh, void *pl);

WARNING:LONG_LINE: line length of 163 exceeds 80 columns
#244: FILE: lib/hci_lib.h:72:
+int hci_signal_le_con_param_update_req(int dd, uint16_t handle, uint16_t interval_min, uint16_t interval_max, uint16_t slave_latency, uint16_t timeout_multiplier);

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#272: FILE: tools/hcitool.c:3388:
+    int options = 0;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#306: FILE: tools/hcitool.c:3422:
+        options = 1;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#306: FILE: tools/hcitool.c:3422:
+        options = 1;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#309: FILE: tools/hcitool.c:3425:
+    if (options == 0) {$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (4, 16)
#309: FILE: tools/hcitool.c:3425:
+    if (options == 0) {
+		helper_arg(5, 5, &argc, &argv, acl_lecup_help);

ERROR:CODE_INDENT: code indent should use tabs where possible
#334: FILE: tools/hcitool.c:3450:
+            handle, min, max, latency, timeout);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#334: FILE: tools/hcitool.c:3450:
+            handle, min, max, latency, timeout);$

WARNING:LONG_LINE: line length of 89 exceeds 80 columns
#335: FILE: tools/hcitool.c:3451:
+	if (hci_signal_le_con_param_update_req(dd, htobs(handle), htobs(min), htobs(max),

WARNING:LONG_LINE: line length of 82 exceeds 80 columns
#336: FILE: tools/hcitool.c:3452:
+                                            htobs(latency), htobs(timeout)) < 0) {

ERROR:CODE_INDENT: code indent should use tabs where possible
#336: FILE: tools/hcitool.c:3452:
+                                            htobs(latency), htobs(timeout)) < 0) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#336: FILE: tools/hcitool.c:3452:
+                                            htobs(latency), htobs(timeout)) < 0) {$

WARNING:LINE_SPACING: Missing a blank line after declarations
#338: FILE: tools/hcitool.c:3454:
+		int err = -errno;
+		fprintf(stderr, "Could not change connection params: %s(%d)\n",

/github/workspace/src/src/13739894.patch total: 7 errors, 20 warnings, 224 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

NOTE: Whitespace errors detected.
      You may wish to use scripts/cleanpatch or scripts/cleanfile

/github/workspace/src/src/13739894.patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.


##############################
Test: GitLint - FAIL
Desc: Run gitlint
Output:
[BlueZ,v1] hcitool - Added option for Peripheral Initiated Connection Parameter Update Request.

WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
1: T1 Title exceeds max length (95>80): "[BlueZ,v1] hcitool - Added option for Peripheral Initiated Connection Parameter Update Request."
1: T3 Title has trailing punctuation (.): "[BlueZ,v1] hcitool - Added option for Peripheral Initiated Connection Parameter Update Request."
##############################
Test: ScanBuild - WARNING
Desc: Run Scan Build
Output:
tools/hcitool.c:3404:13: warning: Null pointer passed to 1st parameter expecting 'nonnull'
                        handle = strtoul(optarg, NULL, base);
                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/hcitool.c:3407:10: warning: Null pointer passed to 1st parameter expecting 'nonnull'
                        min = strtoul(optarg, NULL, base);
                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/hcitool.c:3410:10: warning: Null pointer passed to 1st parameter expecting 'nonnull'
                        max = strtoul(optarg, NULL, base);
                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/hcitool.c:3413:14: warning: Null pointer passed to 1st parameter expecting 'nonnull'
                        latency = strtoul(optarg, NULL, base);
                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/hcitool.c:3416:14: warning: Null pointer passed to 1st parameter expecting 'nonnull'
                        timeout = strtoul(optarg, NULL, base);
                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~
5 warnings generated.



---
Regards,
Linux Bluetooth