All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: iwd@lists.01.org
Subject: Re: [PATCH] eap-gtc: Try to auth even if request not Password
Date: Wed, 11 Dec 2019 14:57:26 -0600	[thread overview]
Message-ID: <66a25792-2327-b3c8-d324-e7b353abcbe1@gmail.com> (raw)
In-Reply-To: <20191211123904.27413-1-xdavidwuph@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 901 bytes --]

Hi,

On 12/11/19 6:39 AM, xdavidwu wrote:
> There are some server implementations that send requests that are
> not "Password" but still want us send password. This commit modify
> the behavior to send a warning and still try to auth with password.
> 
> This makes me able to auth with server in my school which sends
> "Enter Aruba Login".
> 
> wpa_supplicant does not check if it is "Password".
> ---
>   src/eap-gtc.c | 12 +++---------
>   1 file changed, 3 insertions(+), 9 deletions(-)
>

Thanks for the patch.  Looks good.  Any chance you can resubmit with 
your real name as the author info so I can apply this?  While we don't 
use Signed-off-by, our expectation for submissions are similar to [1], 
including the real name requirement.

[1] 
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#developer-s-certificate-of-origin-1-1

Regards,
-Denis

  reply	other threads:[~2019-12-11 20:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-11 12:39 [PATCH] eap-gtc: Try to auth even if request not Password xdavidwu
2019-12-11 20:57 ` Denis Kenzior [this message]
2019-12-12  1:23   ` Pinghao Wu
2019-12-12 16:24     ` Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=66a25792-2327-b3c8-d324-e7b353abcbe1@gmail.com \
    --to=denkenz@gmail.com \
    --cc=iwd@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.