From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9BDFCD4F24 for ; Wed, 4 Sep 2024 20:04:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5A1306B02EE; Wed, 4 Sep 2024 16:04:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 55CBF6B02F0; Wed, 4 Sep 2024 16:04:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3CC316B02EE; Wed, 4 Sep 2024 16:04:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D92066B02E7 for ; Wed, 4 Sep 2024 16:04:19 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 5B6AF41791 for ; Wed, 4 Sep 2024 20:04:19 +0000 (UTC) X-FDA: 82528132638.06.5F35882 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) by imf16.hostedemail.com (Postfix) with ESMTP id 7D8FC180028 for ; Wed, 4 Sep 2024 20:04:16 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="Hxkr8/0J"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf16.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.215.179 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725480178; a=rsa-sha256; cv=none; b=QMGNgnJ8SJiU0el4nWlMLyT0TaoaxJjYFgHi5uSoZsNdMSeS+vr8Q537i6UKew4grIkHQ+ 6suc+eJSjjJRvkLkINB/8Ab0219MZ0jv3XHXqvtyuIFpwke3HN0nb0LFd+DxYDxDh3aOlc 8Wp6tBBNe41oYtEARwxuDuvOdwRPSQQ= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="Hxkr8/0J"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf16.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.215.179 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725480178; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7P01zdosL/Ew6te7Jee/NFhd5KWytMh+G9FICWSXg50=; b=W2zgv5Sr+9O7kPNNGhJRz7LUeUIGMFuIBpq7MhH3Y/V3+KzXpnizSF4Hym+dz+kbFqYW1q tBjy6bivd3z99FxnBSxXP3Ku0JFjnjUERUZvY5NlgmQV/fG2izbMNF/sK6FsRXdshdS71z PkIq3TxF1+/X5llqMVN6thhSncrpKng= Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-7cd8803fe0aso41263a12.0 for ; Wed, 04 Sep 2024 13:04:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725480255; x=1726085055; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=7P01zdosL/Ew6te7Jee/NFhd5KWytMh+G9FICWSXg50=; b=Hxkr8/0JBf0/HjCtSI2+FoXbl6gyJ3A2a2dHd27P/e6e373l1wWBcR2+RDvaFkCibV bPO3Ud4FQFRPCkHAgqOFmjVIz8ON+9iY5zVod3mY+tuUDnkkBAxy6QgWWlQH1mMYhWh8 WSmTHkamE49DPBQLLqc74j/K1jIjbTF8uQe1nm4fOvEnL1VPqWCvE+dmc/BRL7JrkI38 h6VvQRsCEAC7fs1JLYIVuDiGRPJlUtxqte+ddg+q3HnAOmWLtzKj3bMVsrs7t5E88M0r D3oAkcTcZZdlXGcmSjrT/5v1cQhmopZmRdYybpSPNyky/CfTOZ5h9ZojdkCIXkRTMpmO lqdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725480255; x=1726085055; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7P01zdosL/Ew6te7Jee/NFhd5KWytMh+G9FICWSXg50=; b=n2akdQrkAHUzst73B8bWhArXXTVp+Fe4+GpQhBHQ9U6EMjpNZ4ggpXuZe+U1NtbTI5 uD181NbIafjk5LG2J/vURYA9ptbap1420XSV3vau6LFA9/wfcO9436nu3oFcag/qKs+y xR1Goe7gUbaEL7g1qi5uLErrk4mbz3FGObrLDFGWA+CJef3T7jPxrrTBPQAb0/j25YTL xOvt32g9RGYXqyHN7RvY2KdUXlnAyaQ55G9ANnbdSTUYinxO8vvKrsX6a0dfcPJI21Wl jyAgB7TvmmVzSnj2WZfB72fZOq/izCu8Rd0oaZkP547GksZ2CYpBKAknntN+VoycVso2 Ka/w== X-Forwarded-Encrypted: i=1; AJvYcCXaePI08s0wrKic7flL/pf716OIrFhWUnFoz5bJ3GlcYhW3yHG7hZR07wxqzQMqEnqfHIT2vcMETg==@kvack.org X-Gm-Message-State: AOJu0YxNbM1zfmbCPtc/3xgyjye8i9aaWLHHe1bxY1DJORptRcWuQB6S p7ZGOsppYEvx9jkGOuDz/5/SvLgwd8cWRe5RgC9VrT03btowdShI X-Google-Smtp-Source: AGHT+IEoupr+sdgE5S7hpAYxcU7rovNwhSDGb7GQdjQ7KQ4AA1F5858sPAcOf/1h9zP1BirAMX5E5g== X-Received: by 2002:a17:90a:ce90:b0:2d8:6f73:55a with SMTP id 98e67ed59e1d1-2d86f7305edmr18806198a91.25.1725480255089; Wed, 04 Sep 2024 13:04:15 -0700 (PDT) Received: from DESKTOP-DUKSS9G. (c-76-133-131-165.hsd1.ca.comcast.net. [76.133.131.165]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2da6a50265esm4105761a91.51.2024.09.04.13.04.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Sep 2024 13:04:14 -0700 (PDT) Message-ID: <66d8bd3e.170a0220.18832.0206@mx.google.com> X-Google-Original-Message-ID: Date: Wed, 4 Sep 2024 13:04:11 -0700 From: Vishal Moola To: Alex Shi Cc: alexs@kernel.org, Vitaly Wool , Miaohe Lin , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, minchan@kernel.org, willy@infradead.org, senozhatsky@chromium.org, david@redhat.com, 42.hyeyoo@gmail.com, Yosry Ahmed , nphamcs@gmail.com Subject: Re: [PATCH v7 00/21] mm/zsmalloc: add zpdesc memory descriptor for zswap.zpool References: <20240902072136.578720-1-alexs@kernel.org> <0a10e61b-f0e6-4423-996c-7884c93af65f@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0a10e61b-f0e6-4423-996c-7884c93af65f@gmail.com> X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 7D8FC180028 X-Stat-Signature: oyg1rcj8txxzkogi5ipw8z65d9cw3m5y X-Rspam-User: X-HE-Tag: 1725480256-945002 X-HE-Meta: U2FsdGVkX1/+VQSblgYLpPRvp4gH4MwzKs2oDRw8UcL/9e4YrX7mYeVpzJ5Y1alpvVmZhmvihPobM9axHzoDSCLeO2fQxX9paD1UrC9ES5hnG0Rq4FzD3T6T5L4genJfuYse3kNS/FKXrzWk7hlJ3yWtitgU375RPXFuhXf9/1hajNsrzx1lC2tJxjIyJtviRJDksn6hiqFdFviwnCv9zS4dPCNlcUvDt2zlwzMOUXDrXkpPpK82m3ab5+JQn5KBLhvzbm0ebovNhyhYMfr6Vj7fsu02vuTREtKNNYNpMds30EeTbTCYkcFPxLDfdAu1TewdMuLdgAXLmTQbOlU8PXoTeg5ZDxTEEg1EFFgujR6KRl09j88qqYMjzHzAANrZJgrcdtUkbDCJGHTP+A8Y/dahQzhhtnf6BMoK5EV6CGvwPcB8MU8rmeNA48eDeTRl0Xpns6xMlUZb0jBqsvYZTC6VZrz3Xz34zauBvZ2gguEp056zQD+fAIocy00RrC2/GhWr7XtTS9mptmI+m9kJ3kwTW752Xqp5oj4sHP8Sq6NUhlC+PhVDAtEySyJGdSBvMlVyZll/QymeP/KmFm+UPNw6vKn+sAHy84yNEy7pW74HwQQYBdQDY2RNFcTS/kEX1QFx5AgB2MFeAHy8N3Gzsr1wpVRy0vqDcXayoN95LsjSTqD20v5n6DWvkuZ0EI38DM/KLS6hiP0ASpG+TiEKKm7sDgKTSHIIjPyyji2bpKokbET6iiOi+AHTgJ84BhUzWlnB2ASbsN6AT2vJ8xdFBdh2sYTrQaML/2BbfzEnlVWNQwgS9OU7eSmxWhIwJ2vVRjSrGW3N1tvicVhAGBP3yNF07MkXXt1pJXbzmwPI/Wcj4PTXHZRWa5jfOHTk1q2mzuvp3It6+mL4oaCG9CHc9kEb+yinoQkCQFc26vUcmJOG5kNYAf7EMOqu060ufftopY6rvlo2tGKtFLxL5fW 4VYVdeKv 0MWtESalt5eTrqUKdOeD6yHv093nBlPuOPmy9MWvl7XHeq+QesRnlDbux97MDYRAK/wjc51l0KOUllIkMrR7pYJgeNTLQ3zp6lOU1cfD++JO8dCM0IvLsau8DsiZX8s9YExHIEApR/z0qnI9YUMA4Vo7M0EpvudGMIQQCzlA4lSoLcK9jpsIV2iySAB0RCw3ahSpDO+aQAUnmHJCLAVgWu7rk51w0zz3lI4UZP1uXUikWrVrDtjZ9wgJkIgdjgT2ogE4PRdVqWn+ZE0MBBYbBEbqI/lebvEK6CIEzcKAKLUfmvKhV/uY6NeiCSm59woPa5ImdY+FCLwrOxijYk7J2qgmyrfvhxY6T3g6+7oqBUTdHw1pDGMCOy84P+2e/+QUIBYmp3mb71Dkiy/2vsMyTOEpvpMMIqPN001giphcTTVGvfH6RH2pyRzXsduekHONBdetH7SDUJMPzdQ9U0cdi7NIzOOl+6+rAIS0UNJpAPA6Q5CU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000670, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Sep 04, 2024 at 02:54:14PM +0800, Alex Shi wrote: > > > On 9/2/24 3:21 PM, alexs@kernel.org wrote: > > From: Alex Shi > > > ... > > > > > This patchset abstracts the memory descriptor used in zsmalloc by zswap/zram. > > The descriptor still overlays the struct page; nothing has changed > > in that regard. What this patchset accomplishes is the use of folios in > > to save some code size, and the introduction of a new concept, zpdesc. > > This patchset is just an initial step; it does not bias the potential > > changes to kmem_alloc or larger zspage modifications. > > > ... > > > > Thanks a lot for comments and suggestion from Yosry, Yoo, Sergey, Willy > > and Vishal! > > > > This patchset could save 6.3% code size, and it's a nice abstract of zsmalloc > memory usage. > Is there any more comments, or mind to give a reviewed-by? Please CC me on future versions. Most of the zsmalloc conversions seem ok, but I'd hold off on further iterations of the descriptor patches until the maintainers decide on what/how this descriptor will be used (i.e. our end goals). > Thanks > Alex