From: Radha Ramachandran <radha@google.com>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: fio@vger.kernel.org
Subject: Re: Fix race condition when using asynch verify
Date: Tue, 3 Nov 2009 13:43:35 -0800 [thread overview]
Message-ID: <66dfd3fe0911031343j28762e13i5dafdc8c9de50b00@mail.gmail.com> (raw)
In-Reply-To: <20091103204704.GO8742@kernel.dk>
Looks good.
Thanks
-radha
On Tue, Nov 3, 2009 at 12:47 PM, Jens Axboe <jens.axboe@oracle.com> wrote:
> On Tue, Nov 03 2009, Jens Axboe wrote:
>> On Tue, Nov 03 2009, Radha Ramachandran wrote:
>> > Hi,
>> > I discovered the race condition when using asynch verify with libaio engine.
>> > The code assumes that because the td->cur_depth value is not 0 that
>> > there is still I/O pending and issues io_getevents when the I/O was
>> > actually being verified by the asynchronous verify thread. This causes
>> > the code to hang.
>> >
>> > I have attached a patch along to fix this issue.
>>
>> Thanks for the fix, that is indeed a race. I'll merge your patch, but
>> change the io_u->in_cur_depth to be a IO_U_F_ flag.
>
> This is what I commited:
>
> http://git.kernel.dk/?p=fio.git;a=commit;h=0c41214ff4e6f31f8df64aac37be7853aada6f1f
>
> Please double check, thanks!
>
> --
> Jens Axboe
>
> --
> To unsubscribe from this list: send the line "unsubscribe fio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2009-11-03 21:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-03 20:40 Fix race condition when using asynch verify Radha Ramachandran
2009-11-03 20:42 ` Jens Axboe
2009-11-03 20:47 ` Jens Axboe
2009-11-03 21:43 ` Radha Ramachandran [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66dfd3fe0911031343j28762e13i5dafdc8c9de50b00@mail.gmail.com \
--to=radha@google.com \
--cc=fio@vger.kernel.org \
--cc=jens.axboe@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.