From: Yonghong Song <yonghong.song@linux.dev>
To: Sami Tolvanen <samitolvanen@google.com>, bpf@vger.kernel.org
Cc: Vadim Fedorenko <vadim.fedorenko@linux.dev>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
Eduard Zingerman <eddyz87@gmail.com>, Song Liu <song@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>, Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH bpf-next v3 1/4] bpf: crypto: Use the correct destructor kfunc type
Date: Mon, 28 Jul 2025 16:07:49 -0700 [thread overview]
Message-ID: <66f4a64c-a6fa-478b-bc79-495a9def10c8@linux.dev> (raw)
In-Reply-To: <20250728202656.559071-7-samitolvanen@google.com>
On 7/28/25 1:26 PM, Sami Tolvanen wrote:
> With CONFIG_CFI_CLANG enabled, the kernel strictly enforces that
> indirect function calls use a function pointer type that matches the
> target function. I ran into the following type mismatch when running
> BPF self-tests:
>
> CFI failure at bpf_obj_free_fields+0x190/0x238 (target:
> bpf_crypto_ctx_release+0x0/0x94; expected type: 0xa488ebfc)
> Internal error: Oops - CFI: 00000000f2008228 [#1] SMP
> ...
>
> As bpf_crypto_ctx_release() is also used in BPF programs and using
> a void pointer as the argument would make the verifier unhappy, add
> a simple stub function with the correct type and register it as the
> destructor kfunc instead.
>
> Signed-off-by: Sami Tolvanen <samitolvanen@google.com>
Acked-by: Yonghong Song <yonghong.song@linux.dev>
next prev parent reply other threads:[~2025-07-28 23:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-28 20:26 [PATCH bpf-next v3 0/4] Use correct destructor kfunc types Sami Tolvanen
2025-07-28 20:26 ` [PATCH bpf-next v3 1/4] bpf: crypto: Use the correct destructor kfunc type Sami Tolvanen
2025-07-28 23:07 ` Yonghong Song [this message]
2025-07-29 17:54 ` kernel test robot
2025-07-29 18:17 ` Sami Tolvanen
2025-11-21 16:06 ` Viktor Malik
2025-11-25 20:16 ` Sami Tolvanen
2025-11-26 6:16 ` Viktor Malik
2025-07-28 20:26 ` [PATCH bpf-next v3 2/4] bpf: net_sched: " Sami Tolvanen
2025-07-28 23:08 ` Yonghong Song
2025-07-28 20:27 ` [PATCH bpf-next v3 3/4] selftests/bpf: " Sami Tolvanen
2025-07-28 23:08 ` Yonghong Song
2025-07-28 20:27 ` [PATCH bpf-next v3 4/4] bpf, btf: Enforce destructor kfunc type with CFI Sami Tolvanen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66f4a64c-a6fa-478b-bc79-495a9def10c8@linux.dev \
--to=yonghong.song@linux.dev \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=samitolvanen@google.com \
--cc=sdf@fomichev.me \
--cc=song@kernel.org \
--cc=vadim.fedorenko@linux.dev \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.