From: Martin KaFai Lau <martin.lau@linux.dev>
To: Kui-Feng Lee <kuifeng@meta.com>
Cc: bpf@vger.kernel.org, ast@kernel.org, song@kernel.org,
kernel-team@meta.com, andrii@kernel.org, sdf@google.com
Subject: Re: [PATCH bpf-next v12 8/8] selftests/bpf: Test switching TCP Congestion Control algorithms.
Date: Wed, 22 Mar 2023 23:05:45 -0700 [thread overview]
Message-ID: <66f97e66-895c-1cb3-91e3-ac960ef098dd@linux.dev> (raw)
In-Reply-To: <20230323032405.3735486-9-kuifeng@meta.com>
On 3/22/23 8:24 PM, Kui-Feng Lee wrote:
> +static void test_link_replace(void)
> +{
> + DECLARE_LIBBPF_OPTS(bpf_link_update_opts, opts);
> + struct tcp_ca_update *skel;
> + struct bpf_link *link;
> + int err;
> +
> + skel = tcp_ca_update__open_and_load();
> + if (!ASSERT_OK_PTR(skel, "open"))
> + return;
> +
> + link = bpf_map__attach_struct_ops(skel->maps.ca_update_1);
> + ASSERT_OK_PTR(link, "attach_struct_ops_1st");
> + bpf_link__destroy(link);
> +
> + link = bpf_map__attach_struct_ops(skel->maps.ca_update_2);
> + ASSERT_OK_PTR(link, "attach_struct_ops_1st");
I fixed this up s/1st/2nd/. Also,
added a 'if (!ret)' check before synchronize_rcu() in patch 2.
massaged the comment in bpf_struct_ops_map_free in patch1.
The set is applied. Thanks.
next prev parent reply other threads:[~2023-03-23 6:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 3:23 [PATCH bpf-next v12 0/8] Transit between BPF TCP congestion controls Kui-Feng Lee
2023-03-23 3:23 ` [PATCH bpf-next v12 1/8] bpf: Retire the struct_ops map kvalue->refcnt Kui-Feng Lee
2023-03-23 3:23 ` [PATCH bpf-next v12 2/8] net: Update an existing TCP congestion control algorithm Kui-Feng Lee
2023-03-23 3:24 ` [PATCH bpf-next v12 3/8] bpf: Create links for BPF struct_ops maps Kui-Feng Lee
2023-03-23 3:24 ` [PATCH bpf-next v12 4/8] libbpf: Create a bpf_link in bpf_map__attach_struct_ops() Kui-Feng Lee
2023-03-23 3:24 ` [PATCH bpf-next v12 5/8] bpf: Update the struct_ops of a bpf_link Kui-Feng Lee
2023-03-23 3:24 ` [PATCH bpf-next v12 6/8] libbpf: Update a bpf_link with another struct_ops Kui-Feng Lee
2023-03-23 3:24 ` [PATCH bpf-next v12 7/8] libbpf: Use .struct_ops.link section to indicate a struct_ops with a link Kui-Feng Lee
2023-03-23 3:24 ` [PATCH bpf-next v12 8/8] selftests/bpf: Test switching TCP Congestion Control algorithms Kui-Feng Lee
2023-03-23 6:05 ` Martin KaFai Lau [this message]
2023-03-23 14:50 ` Kui-Feng Lee
2023-03-23 6:10 ` [PATCH bpf-next v12 0/8] Transit between BPF TCP congestion controls patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66f97e66-895c-1cb3-91e3-ac960ef098dd@linux.dev \
--to=martin.lau@linux.dev \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=kernel-team@meta.com \
--cc=kuifeng@meta.com \
--cc=sdf@google.com \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.