From: David Hildenbrand <david@redhat.com>
To: Janosch Frank <frankja@linux.ibm.com>, kvm@vger.kernel.org
Cc: thuth@redhat.com, borntraeger@de.ibm.com,
linux-s390@vger.kernel.org, cohuck@redhat.com
Subject: Re: [kvm-unit-tests PATCH v3 4/9] s390x: smp: Rework cpu start and active tracking
Date: Mon, 20 Jan 2020 15:53:26 +0100 [thread overview]
Message-ID: <66fde098-e238-e590-a9c5-44c552e1a32b@redhat.com> (raw)
In-Reply-To: <22cbcc9d-1d32-a5c9-4f3f-7892e28bc705@linux.ibm.com>
> Well, I have restarts in the smp test and I don't want to always pass a
> psw if I know what the last restart psw was.
> Simply restarting into test_func or wait_for_flag is certainly no problem.
>
>>
Makes sense.
>>> + rc = sigp(addr, SIGP_RESTART, 0, NULL);
>>> + if (rc)
>>> + return rc;
>>> + /*
>>> + * The order has been accepted, but the actual restart may not
>>> + * have been performed yet, so wait until the cpu is running.
>>> + */
>>> + while (!smp_cpu_running(addr))
>>> + mb();
>>
>> Should you make sure to stop the CPU before issuing the restart?
>> Otherwise you will get false positives if it is still running (but
>> hasn't processed the RESTART yet)
>
> Good point
>
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2020-01-20 14:53 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 10:46 [kvm-unit-tests PATCH v3 0/9] s390x: smp: Improve smp code and reset checks Janosch Frank
2020-01-17 10:46 ` [kvm-unit-tests PATCH v3 1/9] s390x: smp: Cleanup smp.c Janosch Frank
2020-01-20 12:02 ` David Hildenbrand
2020-01-17 10:46 ` [kvm-unit-tests PATCH v3 2/9] s390x: smp: Only use smp_cpu_setup once Janosch Frank
2020-01-17 10:46 ` [kvm-unit-tests PATCH v3 3/9] s390x: Add cpu id to interrupt error prints Janosch Frank
2020-01-17 10:46 ` [kvm-unit-tests PATCH v3 4/9] s390x: smp: Rework cpu start and active tracking Janosch Frank
2020-01-20 12:06 ` David Hildenbrand
2020-01-20 13:16 ` Thomas Huth
2020-01-20 13:20 ` David Hildenbrand
2020-01-20 14:47 ` Janosch Frank
2020-01-20 14:53 ` David Hildenbrand [this message]
2020-01-17 10:46 ` [kvm-unit-tests PATCH v3 5/9] s390x: smp: Wait for cpu setup to finish Janosch Frank
2020-01-20 11:04 ` Cornelia Huck
2020-01-20 12:07 ` David Hildenbrand
2020-01-17 10:46 ` [kvm-unit-tests PATCH v3 6/9] s390x: smp: Loop if secondary cpu returns into cpu setup again Janosch Frank
2020-01-20 11:27 ` Cornelia Huck
2020-01-20 12:07 ` David Hildenbrand
2020-01-17 10:46 ` [kvm-unit-tests PATCH v3 7/9] s390x: smp: Remove unneeded cpu loops Janosch Frank
2020-01-20 11:29 ` Cornelia Huck
2020-01-20 14:41 ` Janosch Frank
2020-01-20 16:11 ` Cornelia Huck
2020-01-21 12:46 ` Janosch Frank
2020-01-21 12:59 ` Cornelia Huck
2020-01-21 13:07 ` Janosch Frank
2020-01-17 10:46 ` [kvm-unit-tests PATCH v3 8/9] s390x: smp: Test all CRs on initial reset Janosch Frank
2020-01-20 11:44 ` Cornelia Huck
2020-01-20 12:10 ` David Hildenbrand
2020-01-20 14:49 ` Janosch Frank
2020-01-20 14:53 ` David Hildenbrand
2020-01-17 10:46 ` [kvm-unit-tests PATCH v3 9/9] s390x: smp: Dirty fpc before initial reset test Janosch Frank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66fde098-e238-e590-a9c5-44c552e1a32b@redhat.com \
--to=david@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.