From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D12315C14F for ; Wed, 16 Oct 2024 02:24:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729045446; cv=none; b=GiO1+bOepycrp4iC28lTI74OI2i8nZzHQRiFVcOJj6y8IDa0nIUZIqbnt2NNjdL4ZKRHR4iVJEd/10crOsMt+lqxP11RWYwZjrq5Zxr8joLq7LQEv+SGAenLLLxkRE+2K50dZRo6jgTYLRsa/S149Gp7svMtkeMFCS4c+hQ/XzA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729045446; c=relaxed/simple; bh=vkFin8YAkk9Wiv1FM6Rwn193R82QUFJ0lMHnYMg5PW8=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=spHWb87CN0kwTEPFnKLgxpCpm1JNmWMo79aByuIIuPoGkFqajKFuuoHHJgZRhLVbGMTQxY2faoKf4M7ed8FHgUjkJohP23YPP/h4uIrJKmXsqPMCoLwXNvybbTCGESJMSiTFHwFnSvFPLCTU+FPzpQn87WNRvtuKGlVKMV0lGow= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=joelfernandes.org; spf=pass smtp.mailfrom=joelfernandes.org; dkim=pass (1024-bit key) header.d=joelfernandes.org header.i=@joelfernandes.org header.b=KdVlktDk; arc=none smtp.client-ip=209.85.160.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=joelfernandes.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=joelfernandes.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=joelfernandes.org header.i=@joelfernandes.org header.b="KdVlktDk" Received: by mail-qt1-f174.google.com with SMTP id d75a77b69052e-460489eec46so67158131cf.0 for ; Tue, 15 Oct 2024 19:24:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; t=1729045444; x=1729650244; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=rSM5JzEpw8IEvYl8Wi1gclJRID81zECxLDVfM6LHr2o=; b=KdVlktDkDJHkWr7HFDsQQHLqYLaHgT1E396S+UnUXghwn7T1HNdjC1PSsHNIcfm3za 74ThQGHppDbKkl5FmUp03FrB2qv6SCgFExp07/GT0uF2fSnUmr3s5goWsd7YETMzEM0X A57kjMF+uUYKjlQOh1Yrvv1j6HhDNJ0cI5PF8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729045444; x=1729650244; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rSM5JzEpw8IEvYl8Wi1gclJRID81zECxLDVfM6LHr2o=; b=B0e3weLtA5lIaiLKCWtjDkS/lJcSEfF1tBgS4qBNNKon0RMIRieD1vxQtzm4nmg+/E nfjmBP2Uk+OnotoZ0S4rHvYpyzFJZDwaX8O0uMjXDgJGeXSvDOb/hRnPszZ2Ir8qyBa9 0GrP3sWsN8FU3rAxG9zfjnplWf/jhSAz1aS32l2c1ZEjjEUYMR+vIV7RRIk3nqrJNLau pjxmhUg+nDha9zl5bHfd+pvN52ZxrZFYPsVPopPjWLwFLXyRYKPAZW2ImwT0mCSGW2Kv 7ohHMrxC+1Xi/FZOWgdhGewsFWjA/di46Sv3hme8HWV8r2uISj+1pWrKFUL05d+8OwTh WPcw== X-Forwarded-Encrypted: i=1; AJvYcCXYVmCZCoWxkDqPoE34fQav95w03/+OgV+sYJCD5cdTEse1AekKcDnTBwRzdU8SY2PfK57Q2J4=@vger.kernel.org X-Gm-Message-State: AOJu0YyG41L+5hU/BZG6lCYOVYxNuaRL3IdQmkqNVYssJc0Ujksq3UCi 8di96qSjgpoTrGapwDovETuH2BT0VJ/afZ+Ci4t8nxbEAmwr3CbyGWSu3jGqvYo= X-Google-Smtp-Source: AGHT+IFWCC/S9dXsp+A051MHox+o20A3NL3tpfTZfFxD6YcOo1vnCybm1oZluCcvQ9PpRfE9CJMD1A== X-Received: by 2002:ac8:5806:0:b0:458:2523:c060 with SMTP id d75a77b69052e-4605844500amr232582351cf.29.1729045444189; Tue, 15 Oct 2024 19:24:04 -0700 (PDT) Received: from localhost ([91.196.69.99]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4607b0a3fa3sm12755241cf.5.2024.10.15.19.24.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Oct 2024 19:24:03 -0700 (PDT) Message-ID: <670f23c3.050a0220.1fe46c.5dd2@mx.google.com> X-Google-Original-Message-ID: <20241016022358.GA117803@JoelBox.> Date: Tue, 15 Oct 2024 22:23:58 -0400 From: Joel Fernandes To: Jakub Kicinski Cc: paulmck@kernel.org, netdev@vger.kernel.org, frederic@kernel.org, neeraj.upadhyay@kernel.org, rcu@vger.kernel.org, linux-kernel@vger.kernel.org, kees@kernel.org, matttbe@kernel.org Subject: Re: [PATCH rcu] configs/debug: make sure PROVE_RCU_LIST=y takes effect References: <20241016011144.3058445-1-kuba@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241016011144.3058445-1-kuba@kernel.org> On Tue, Oct 15, 2024 at 06:11:44PM -0700, Jakub Kicinski wrote: > Commit 0aaa8977acbf ("configs: introduce debug.config for CI-like setup") > added CONFIG_PROVE_RCU_LIST=y to the common CI config, > but RCU_EXPERT is not set, and it's a dependency for > CONFIG_PROVE_RCU_LIST=y. Make sure CIs take advantage > of CONFIG_PROVE_RCU_LIST=y, recent fixes in networking > indicate that it does catch bugs. > > Signed-off-by: Jakub Kicinski Reviewed-by: Joel Fernandes (Google) thanks, - Joel > --- > I'd be slightly tempted to still send it to Linux for v6.12. > > CC: paulmck@kernel.org > CC: frederic@kernel.org > CC: neeraj.upadhyay@kernel.org > CC: joel@joelfernandes.org > CC: rcu@vger.kernel.org > CC: linux-kernel@vger.kernel.org > CC: kees@kernel.org > CC: matttbe@kernel.org > --- > kernel/configs/debug.config | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/kernel/configs/debug.config b/kernel/configs/debug.config > index 509ee703de15..20552f163930 100644 > --- a/kernel/configs/debug.config > +++ b/kernel/configs/debug.config > @@ -103,6 +103,7 @@ CONFIG_BUG_ON_DATA_CORRUPTION=y > # > # RCU Debugging > # > +CONFIG_RCU_EXPERT=y > CONFIG_PROVE_RCU=y > CONFIG_PROVE_RCU_LIST=y > # > -- > 2.46.2 >