From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a17:504:c05:b0:1be9:327d:8ee3 with SMTP id k5csp1315635njf; Mon, 28 Oct 2024 01:41:58 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUQ9wtduW7vao7QDsvfkrH02JQDnPnNuOOU9GC1i2UY0/ROvaGb7v6ef70GtCo7TIL8xLV7A4RvLimc5A==@linaro.org X-Google-Smtp-Source: AGHT+IHILo1m/AZaYU8IYVFSFtu0PCMTkVsSKNjW0OZlrLo2oYa83qhRSoEZLNzxv6YpPectwAh0 X-Received: by 2002:a05:6214:5d93:b0:6c1:6e3a:6d17 with SMTP id 6a1803df08f44-6d185674992mr151930146d6.6.1730104918577; Mon, 28 Oct 2024 01:41:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1730104918; cv=none; d=google.com; s=arc-20240605; b=kooIFVCGD8PbnPU9qCHYxLnW02MHIWMvd5faVE0dwMIgEWugEgEdlGXchfue7yZblB 7rmYKKKuFl+odwtjBRJylZwPL3l60hPGNjAGjCt6Qf5TSahc+1XFEPxn9BJ9Un7nJqYn 6ZvtWHg65K2MWaKYc4oTnCp8SKl3V6dKTV7obv4imZ3G1LrJJinS45R7Y8teD3YsI138 1ncJQHz0g1ZEf3/Cm2vTLO2YlDePEHpdX1MVYHYTdOhRFBWMI0GHkwTOZpFIg6iqFziM uybYznCvLiQWN2iPS5J1Ybwe93ak642es1VMcfd30YPb5Z4c8ILNP8Elw0/MviFQaTbi ojJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:mime-version:user-agent :content-transfer-encoding:references:in-reply-to:date:cc:to:from :subject:message-id; bh=8oZuwjmRF/XL/gsP1GZWNeEPDM+6HRT8oj++PjH9/Aw=; fh=rgtpyvjUnQ0qYmwVj/sRXdUrKdA3ChTKiL3Xcbu8y6M=; b=K3f5s7gxDYV9YSGGKRweiAcxfcv+hUrKN9fFlm9YFc5YmAzfBKI1jP6tL8pYCdXI0L +8zYyWG1NTKAD4E1DfAssbrKxNu5RoCQJ6IAEPQTqd4Fo/AsPjkMT19inAhHnZ+SL0QI zH+xhe1j5oLL8NIXrFX5yJ/JCHGNjt598+9IG/HBFUu71jMjXwrQ+0CSck8Eszus58xG OrJz5cO2DZPY46OwSmdHsHIVJ8WwtSW3pfbsQTHaWlsbv+xOfji4zOO6/wypICjjgTpI oGd7sLQKMjE3MnMdqUraLEFndq6pzJbkc7X0/QN6CcnUWDH7NvETUfGR4Ke4nRqc7a2S ogaQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6d179a7f404si80170266d6.481.2024.10.28.01.41.58 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 28 Oct 2024 01:41:58 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t5LJb-00075H-Og; Mon, 28 Oct 2024 04:41:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t5LJZ-00074t-1a for qemu-devel@nongnu.org; Mon, 28 Oct 2024 04:41:29 -0400 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t5LJX-0002pB-I8 for qemu-devel@nongnu.org; Mon, 28 Oct 2024 04:41:28 -0400 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t5LJA-00020f-Oi; Mon, 28 Oct 2024 09:41:04 +0100 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1t5LJ9-000orQ-2Y; Mon, 28 Oct 2024 09:41:03 +0100 Received: from localhost ([127.0.0.1]) by ptz.office.stw.pengutronix.de with esmtp (Exim 4.96) (envelope-from ) id 1t5LJ9-008dmI-0C; Mon, 28 Oct 2024 09:41:03 +0100 Message-ID: <670fa7bf052d8f292f9bd25c330c8d7bdba02770.camel@pengutronix.de> Subject: Re: [PATCH 0/2] arm: Add collie and sx functional tests From: Jan =?ISO-8859-1?Q?L=FCbbe?= To: Guenter Roeck , =?ISO-8859-1?Q?C=E9dric?= Le Goater , Philippe =?ISO-8859-1?Q?Mathieu-Daud=E9?= Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, Thomas Huth , Peter Maydell , Joel Stanley , qemu-block Date: Mon, 28 Oct 2024 09:41:03 +0100 In-Reply-To: <4246f82b-597c-4a5d-9a55-18a584e7d8c7@roeck-us.net> References: <20241017163247.711244-1-peter.maydell@linaro.org> <5262a33d-d0c5-452b-9869-f8f482b1c857@linaro.org> <07664ec3-6b46-4b27-9d8c-9e2ff34c9dbe@kaod.org> <600baa43c3dd3547338934717cfb57c5e12b0d23.camel@pengutronix.de> <84c32f2d-7d9a-4e5a-8b67-1f954dd493f6@roeck-us.net> <53cbb597-e7f2-4742-bf85-928c704ddbcf@linaro.org> <443f1b0c-8184-4bf4-9f68-c23d7de3bc36@roeck-us.net> <1bce4c22-9281-44c5-8acb-860881dc271c@kaod.org> <86fa6e68-5861-4d4d-941f-95b278074eb6@kaod.org> <1c917e4a-de50-45b9-ac9c-eb04d51401a2@roeck-us.net> <00997cca-6f4a-4b99-9616-2af6a25cd4fb@kaod.org> <4246f82b-597c-4a5d-9a55-18a584e7d8c7@roeck-us.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.1 (by Flathub.org) MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: jlu@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: qemu-devel@nongnu.org Received-SPF: pass client-ip=2a0a:edc0:2:b01:1d::104; envelope-from=jlu@pengutronix.de; helo=metis.whiteo.stw.pengutronix.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: P4F1AwVxj/Mn On Sun, 2024-10-27 at 20:32 -0700, Guenter Roeck wrote: > On 10/27/24 15:26, C=C3=A9dric Le Goater wrote: > > On 10/27/24 23:11, Guenter Roeck wrote: > > > On 10/27/24 14:13, C=C3=A9dric Le Goater wrote: > > > > On 10/26/24 17:32, Guenter Roeck wrote: > > > > > On 10/26/24 03:02, C=C3=A9dric Le Goater wrote: > > > > > [ ... ] > > > > >=20 > > > > > >=20 > > > > > Works for me, though, and it is much better than mandating the ex= istence > > > > > of boot partitions. > > > >=20 > > > > Yes. However, if the emmc device was user creatable, we could use : > > > >=20 > > > > =C2=A0=C2=A0 -blockdev node-name=3Demmc0,driver=3Dfile,filename=3Dm= mc-ast2600-evb-noboot.raw \ > > > > =C2=A0=C2=A0 -device emmc,bus=3Dsdhci-bus.2,drive=3Demmc0 > > > >=20 > > > > and with boot partitions: > > > >=20 > > > > =C2=A0=C2=A0 -M boot-emmc=3Dtrue \ > > > > =C2=A0=C2=A0 -blockdev node-name=3Demmc0,driver=3Dfile,filename=3Dm= mc-ast2600-evb.raw \ > > > > =C2=A0=C2=A0 -device emmc,bus=3Dsdhci-bus.2,drive=3Demmc0,boot-part= ition-size=3D1048576,boot-config=3D8 > > > >=20 > > > > The above would be my preferred approach if acceptable. The "sd-bus= " > > > > bus identifier should be changed in other machines tough. > > >=20 > > > No real preference here, though my understanding is that emmc devices > > > are by definition built-in, and that is what emmc_class_init() says a= s well. > > > Also, there does not seem to be an sdhci-bus, only sd-bus, and that d= oes > > > not support any index values. That may be just my lack of knowledge, = though. > >=20 > > No, you are right. On a real ast2600-evb, the eMMC device is indeed > > soldered on the board. But, for testing purposes, it is sometime > > interesting to add some flexibility in the machine definition and > > in the modeling too. This avoids "hard-coding" default devices in > > the machines and lets the user define its own variant models using > > the QEMU command line. >=20 > I would agree, but I had a number of my patches rejected because while > they would be useful for testing they would not accurately reflect the > hardware. So nowadays I gave up even trying to upstream such changes. My patch to make eMMCs user creatable [1] was applied to target- arm.next by Peter Maydell [2] last week. Jan [1] https://lore.kernel.org/qemu-devel/20241015135649.4189256-1-jlu@pengutr= onix.de/ [2] https://lore.kernel.org/qemu-devel/CAFEAcA9sjszCj=3DFu-A-=3DqQV_jawnomJ= -Nqnd=3DVx2vLKmYZ1-nQ@mail.gmail.com/ --=20 Pengutronix e.K. | | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |