Re: [PATCH] [rpi4b] Make bootable rpi4b model

["Kambalin, Sergey" <sergey.kambalin@auriga.com>]

[-- Attachment #1: Type: text/plain, Size: 1394 bytes --]

Thanks!

________________________________
От: Peter Maydell <peter.maydell@linaro.org>
Отправлено: 22 мая 2023 г. 15:01:26
Кому: Kambalin, Sergey
Копия: Sergey Kambalin; qemu-arm@nongnu.org; qemu-devel@nongnu.org
Тема: Re: [PATCH] [rpi4b] Make bootable rpi4b model

On Mon, 22 May 2023 at 12:42, Kambalin, Sergey
<sergey.kambalin@auriga.com> wrote:
>
> Aw, I thought the entire machine should work at the first patch.
>
> Thank you for the detailed clarification! I think I've got the idea. I'll split it up.
>
> Could you please tell me what size is appropriate for a single patch?

The most important things for patch splitting are:
 * everything still has to compile cleanly
 * the contents of a single patch should be a coherent single
   thing that it makes sense to review in one part

If there's something in there that only touches 20 lines of
code but is a coherent single change, it's fine to have that in
its own patch -- small patches are easy to review.

At the upper end, I tend to think a patch is a bit big
at around 200 lines, but for the specific case of "here
is a new device" bigger than that is OK, because it's
just adding new files rather than merging changes into
existing ones.

https://www.qemu.org/docs/master/devel/submitting-a-patch.html
has some other advice on patch submission, if you haven't
read that yet.

thanks
-- PMM

[-- Attachment #2: Type: text/html, Size: 2582 bytes --]