From: Christian Marangi <ansuelsmth@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Marion & Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Subject: Re: [net-next PATCH] net: dsa: add devm_dsa_register_switch()
Date: Fri, 8 Nov 2024 21:53:48 +0100 [thread overview]
Message-ID: <672e7a61.050a0220.1d1399.6d31@mx.google.com> (raw)
In-Reply-To: <af968377-d4c4-4561-8dc6-6f92ff1ebbf4@lunn.ch>
On Fri, Nov 08, 2024 at 09:35:32PM +0100, Andrew Lunn wrote:
> > +int devm_dsa_register_switch(struct device *dev, struct dsa_switch *ds)
> > +{
> > + int err;
> > +
> > + err = dsa_register_switch(ds);
> > + if (err)
> > + return err;
> > +
> > + return devm_add_action_or_reset(dev, devm_dsa_unregister_switch, ds);
> > +}
> > +EXPORT_SYMBOL_GPL(dsa_register_switch);
>
> This looks to be the wrong function name.
>
Ah... Anyway aside from this, is the feature OK? Questioning why it
wasn't proposed early...
>
> ---
> pw-bot: cr
>
--
Ansuel
next prev parent reply other threads:[~2024-11-08 20:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-08 20:02 [net-next PATCH] net: dsa: add devm_dsa_register_switch() Christian Marangi
2024-11-08 20:35 ` Andrew Lunn
2024-11-08 20:53 ` Christian Marangi [this message]
2024-11-08 21:43 ` Andrew Lunn
2024-11-08 22:22 ` Christophe JAILLET
2024-11-09 2:50 ` kernel test robot
2024-11-09 3:31 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=672e7a61.050a0220.1d1399.6d31@mx.google.com \
--to=ansuelsmth@gmail.com \
--cc=andrew@lunn.ch \
--cc=christophe.jaillet@wanadoo.fr \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.