From: Markus Elfring <Markus.Elfring@web.de>
To: yuebingkun@kylinos.cn, linux-fbdev@vger.kernel.org,
dri-devel@lists.freedesktop.org, Helge Deller <deller@gmx.de>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] fbdev: platinumfb: add error checking for ioremap calls
Date: Mon, 17 Aug 2026 08:28:07 +0200 [thread overview]
Message-ID: <672fbb47-7836-4a02-97e6-30ccf53b9e97@web.de> (raw)
In-Reply-To: <20260817055625.276500-1-yuebingkun@kylinos.cn>
…
> Add proper error checking and cleanup for all three ioremap calls in
> the probe function, ensuring that any resources already allocated are
> properly released on failure.
* Please avoid duplicate source code also in the implementation of the function “platinumfb_probe”.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v7.2-rc7#n526
* How do you think about to increase the application of scope-based resource management?
* Would you like to add any tags (like “Fixes” and “Cc”) accordingly?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.2-rc7#n145
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/stable-kernel-rules.rst?h=v7.2-rc7#n34
Regards,
Markus
next prev parent reply other threads:[~2026-08-17 6:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-17 5:56 [PATCH] fbdev: platinumfb: add error checking for ioremap calls yuebingkun
2026-08-17 6:28 ` Markus Elfring [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-08-17 6:36 yuebingkun
2026-08-17 6:44 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=672fbb47-7836-4a02-97e6-30ccf53b9e97@web.de \
--to=markus.elfring@web.de \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yuebingkun@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.