From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH v2 4/4] drm/i915: Calculate vlv/chv intermediate watermarks correctly, v2. Date: Thu, 4 May 2017 10:12:52 +0200 Message-ID: <6733eab3-0b68-9783-d56d-e76cbd22dcb5@linux.intel.com> References: <20170501133434.5683-1-maarten.lankhorst@linux.intel.com> <20170501133434.5683-5-maarten.lankhorst@linux.intel.com> <20170503134533.GH12629@intel.com> <587a919a-52a9-ed40-9e18-e6da724be1b0@linux.intel.com> <20170503141159.GM12629@intel.com> <3ceb1e81-539d-3290-6089-237403918b26@linux.intel.com> <20170503160758.GP12629@intel.com> <18fc85f7-cd67-4f53-5cdd-d5fadc65fa2e@linux.intel.com> <20170503180353.GQ12629@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6F0D76E026 for ; Thu, 4 May 2017 08:12:55 +0000 (UTC) In-Reply-To: <20170503180353.GQ12629@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T3AgMDMtMDUtMTcgb20gMjA6MDMgc2NocmVlZiBWaWxsZSBTeXJqw6Rsw6Q6Cj4gT24gV2VkLCBN YXkgMDMsIDIwMTcgYXQgMDY6MTg6NDZQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9yc3Qgd3JvdGU6 Cj4+IE9wIDAzLTA1LTE3IG9tIDE4OjA3IHNjaHJlZWYgVmlsbGUgU3lyasOkbMOkOgo+Pj4gT24g V2VkLCBNYXkgMDMsIDIwMTcgYXQgMDU6NTM6MzRQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9yc3Qg d3JvdGU6Cj4+Pj4gT3AgMDMtMDUtMTcgb20gMTY6MTEgc2NocmVlZiBWaWxsZSBTeXJqw6Rsw6Q6 Cj4+Pj4+IE9uIFdlZCwgTWF5IDAzLCAyMDE3IGF0IDA0OjA2OjM3UE0gKzAyMDAsIE1hYXJ0ZW4g TGFua2hvcnN0IHdyb3RlOgo+Pj4+Pj4gT3AgMDMtMDUtMTcgb20gMTU6NDUgc2NocmVlZiBWaWxs ZSBTeXJqw6Rsw6Q6Cj4+Pj4+Pj4gT24gTW9uLCBNYXkgMDEsIDIwMTcgYXQgMDM6MzQ6MzRQTSAr MDIwMCwgTWFhcnRlbiBMYW5raG9yc3Qgd3JvdGU6Cj4+Pj4+Pj4+IFRoZSB3YXRlcm1hcmtzIGl0 IHNob3VsZCBjYWxjdWxhdGUgYWdhaW5zdCBhcmUgdGhlIG9sZCBvcHRpbWFsIHdhdGVybWFya3Mu Cj4+Pj4+Pj4+IFRoZSBjdXJyZW50bHkgYWN0aXZlIGNydGMgd2F0ZXJtYXJrcyBhcmUgcHVyZSBm aWN0aW9uLCBhbmQgYXJlIGludmFsaWQgaW4KPj4+Pj4+Pj4gY2FzZSBvZiBhIG5vbmJsb2NraW5n IG1vZGVzZXQsIHBhZ2UgZmxpcCBlbmFibGluZy9kaXNhYmxpbmcgcGxhbmVzIG9yIGFueQo+Pj4+ Pj4+PiBvdGhlciByZWFzb24uCj4+Pj4+Pj4+Cj4+Pj4+Pj4+IFdoZW4gdGhlIGNydGMgaXMgZGlz YWJsZWQgb3IgZHVyaW5nIGEgbW9kZXNldCB0aGUgaW50ZXJtZWRpYXRlIHdhdGVybWFya3MKPj4+ Pj4+Pj4gZG9uJ3QgbmVlZCB0byBiZSBwcm9ncmFtbWVkIHNlcGFyYXRlbHksIGFuZCBjb3VsZCBi ZSBkaXJlY3RseSBhc3NpZ25lZAo+Pj4+Pj4+PiB0byB0aGUgb3B0aW1hbCB3YXRlcm1hcmtzLgo+ Pj4+Pj4+Pgo+Pj4+Pj4+PiBBbHNvIHJlbmFtZSBjcnRjX3N0YXRlIHRvIG5ld19jcnRjX3N0YXRl LCB0byBkaXN0aW5ndWlzaCBpdCBmcm9tIHRoZSBvbGQgc3RhdGUuCj4+Pj4+Pj4+Cj4+Pj4+Pj4+ IENoYW5nZXMgc2luY2UgdjE6Cj4+Pj4+Pj4+IC0gVXNlIGludGVsX2F0b21pY19nZXRfb2xkX2Ny dGNfc3RhdGUuICh2aWxsZSkKPj4+Pj4+Pj4KPj4+Pj4+Pj4gU2lnbmVkLW9mZi1ieTogTWFhcnRl biBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPj4+Pj4+Pj4g LS0tCj4+Pj4+Pj4+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jIHwgMjAgKysrKysr KysrKysrKystLS0tLS0KPj4+Pj4+Pj4gIDEgZmlsZSBjaGFuZ2VkLCAxNCBpbnNlcnRpb25zKCsp LCA2IGRlbGV0aW9ucygtKQo+Pj4+Pj4+Pgo+Pj4+Pj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfcG0uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMK Pj4+Pj4+Pj4gaW5kZXggMGYzNDRiMWZmZjQ1Li5hMDkzOTZlZTFmM2QgMTAwNjQ0Cj4+Pj4+Pj4+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMKPj4+Pj4+Pj4gKysrIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+Pj4+Pj4+PiBAQCAtMTQ1OCwxNiArMTQ1OCwy NCBAQCBzdGF0aWMgdm9pZCB2bHZfYXRvbWljX3VwZGF0ZV9maWZvKHN0cnVjdCBpbnRlbF9hdG9t aWNfc3RhdGUgKnN0YXRlLAo+Pj4+Pj4+PiAgCj4+Pj4+Pj4+ICBzdGF0aWMgaW50IHZsdl9jb21w dXRlX2ludGVybWVkaWF0ZV93bShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+Pj4+Pj4+PiAgCQkJ CSAgICAgICBzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YywKPj4+Pj4+Pj4gLQkJCQkgICAgICAgc3Ry dWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUpCj4+Pj4+Pj4+ICsJCQkJICAgICAgIHN0 cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpuZXdfY3J0Y19zdGF0ZSkKPj4+Pj4+Pj4gIHsKPj4+Pj4+ Pj4gLQlzdHJ1Y3Qgdmx2X3dtX3N0YXRlICppbnRlcm1lZGlhdGUgPSAmY3J0Y19zdGF0ZS0+d20u dmx2LmludGVybWVkaWF0ZTsKPj4+Pj4+Pj4gLQljb25zdCBzdHJ1Y3Qgdmx2X3dtX3N0YXRlICpv cHRpbWFsID0gJmNydGNfc3RhdGUtPndtLnZsdi5vcHRpbWFsOwo+Pj4+Pj4+PiAtCWNvbnN0IHN0 cnVjdCB2bHZfd21fc3RhdGUgKmFjdGl2ZSA9ICZjcnRjLT53bS5hY3RpdmUudmx2Owo+Pj4+Pj4+ PiArCXN0cnVjdCB2bHZfd21fc3RhdGUgKmludGVybWVkaWF0ZSA9ICZuZXdfY3J0Y19zdGF0ZS0+ d20udmx2LmludGVybWVkaWF0ZTsKPj4+Pj4+Pj4gKwljb25zdCBzdHJ1Y3Qgdmx2X3dtX3N0YXRl ICpvcHRpbWFsID0gJm5ld19jcnRjX3N0YXRlLT53bS52bHYub3B0aW1hbDsKPj4+Pj4+Pj4gKwlj b25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqb2xkX2NydGNfc3RhdGUgPQo+Pj4+Pj4+PiAr CQlpbnRlbF9hdG9taWNfZ2V0X29sZF9jcnRjX3N0YXRlKG5ld19jcnRjX3N0YXRlLT5iYXNlLnN0 YXRlLCBjcnRjKTsKPj4+Pj4+Pj4gKwljb25zdCBzdHJ1Y3Qgdmx2X3dtX3N0YXRlICphY3RpdmUg PSAmb2xkX2NydGNfc3RhdGUtPndtLnZsdi5vcHRpbWFsOwo+Pj4+Pj4+PiAgCWludCBsZXZlbDsK Pj4+Pj4+Pj4gIAo+Pj4+Pj4+PiArCWlmICghbmV3X2NydGNfc3RhdGUtPmJhc2UuYWN0aXZlIHx8 IGRybV9hdG9taWNfY3J0Y19uZWVkc19tb2Rlc2V0KCZuZXdfY3J0Y19zdGF0ZS0+YmFzZSkpIHsK Pj4+Pj4+Pj4gKwkJKmludGVybWVkaWF0ZSA9ICpvcHRpbWFsOwo+Pj4+Pj4+PiArCj4+Pj4+Pj4+ ICsJCXJldHVybiAwOwo+Pj4+Pj4+PiArCX0KPj4+Pj4+Pj4gKwo+Pj4+Pj4+PiAgCWludGVybWVk aWF0ZS0+bnVtX2xldmVscyA9IG1pbihvcHRpbWFsLT5udW1fbGV2ZWxzLCBhY3RpdmUtPm51bV9s ZXZlbHMpOwo+Pj4+Pj4+PiAgCWludGVybWVkaWF0ZS0+Y3hzciA9IG9wdGltYWwtPmN4c3IgJiYg YWN0aXZlLT5jeHNyICYmCj4+Pj4+Pj4+IC0JCSFjcnRjX3N0YXRlLT5kaXNhYmxlX2N4c3I7Cj4+ Pj4+Pj4+ICsJCSFuZXdfY3J0Y19zdGF0ZS0+ZGlzYWJsZV9jeHNyOwo+Pj4+Pj4+IFdlIG5lZWQg dG8gY29uc2lkZXIgZGlzYWJsZV9jeHNyIGV2ZW4gaW4gdGhlIG1vZGVzZXQgY2FzZS4KPj4+Pj4+ IFdoeSBpcyB0aGlzPyBjcnRjX3N0YXRlLT5kaXNhYmxlX2N4c3IgaXMgc2V0IGlmIGFueSBwbGFu ZSBpcyBwYXJ0IG9mIHRoZSBjcnRjIGR1cmluZyBtb2Rlc2V0LCBzbyBpdCdzIGRpc2FibGVkIGR1 cmluZyBtb2Rlc2V0IGFscmVhZHkuCj4+Pj4+IEl0J3Mgc2V0IGlmIGFueSBwbGFuZSBpcyBlbmFi bGluZy9kaXNhYmxpbmcsIHdoaWNoIHNob3VsZCBiZSBxdWl0ZQo+Pj4+PiB0eXBpY2FsIGR1cmlu ZyBhIG1vZGVzZXQuCj4+Pj4gWWVhaCBidXQgLmluaXRpYWxfd2F0ZXJtYXJrcyBpcyBjYWxsZWQg ZHVyaW5nIGNydGNfZW5hYmxlLCBzbyBjeHNyIHdpbGwgZ2V0IGVuYWJsZWQgYW55d2F5Lgo+Pj4g V2hpY2ggaXMgbm90IHdoYXQgd2Ugd2FudC4gQ3hTUiBtdXN0IHN0YXkgb2ZmIHVudGlsIHRoZSBw bGFuZXMgaGF2ZSBiZWVuCj4+PiBlbmFibGVkLgo+Pj4KPj4gSW4gdGhhdCBjYXNlIHdoeSBpcyBp dCBlbmFibGVkIGluIC5pbml0aWFsX3dhdGVybWFya3MgYXQgYWxsPyBJdCBzaG91bGQgYmUgaW4g b3B0aW1pemVfd2F0ZXJtYXJrcyB0aGVuLi4KPiBCZWNhdXNlIHdlIGNhbiBrZWVwIGl0IGVuYWJs ZWQgYWNyb3NzIHRoZSB1cGRhdGUgdW5sZXNzIHBsYW5lcyBhcmUKPiBnZXR0aW5nIGVuYWJsZWQg b3IgZGlzYWJsZWQuCj4KU28gZm9yIHRoZSBtb2Rlc2V0IGNhc2UsIGNvbXB1dGluZyBpbnRlcm1l ZGlhdGUgd2F0ZXJtYXJrczoKCippbnRlcm1lZGlhdGUgPSAqb3B0aW1hbDsKaWYgKG5lZWRzX21v ZGVzZXQpCglpbnRlcm1lZGlhdGUtPmN4c3IgPSBmYWxzZTsKCmlmIChvcHRpbWFsLT5jeHNyICYm ICFpbnRlcm1lZGlhdGUtPmN4c3IpCgluZXdfY3J0Y19zdGF0ZS0+d20ubmVlZF9wb3N0dmJsX3Vw ZGF0ZSA9IHRydWU7Cgo/CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRl bC1nZngK