Re: [PATCH 2/2] selftests: Add membarrier syscall test

[Mathieu Desnoyers <mathieu.desnoyers@efficios.com>]

----- Original Message -----
> On Mon, 2015-05-04 at 17:00 -0400, Mathieu Desnoyers wrote:
> > From: Pranith Kumar <bobby.prani@gmail.com>
> > 
> > This commit adds a selftest for the membarrier system call.
> > 
> > diff --git a/tools/testing/selftests/membarrier/.gitignore
> > b/tools/testing/selftests/membarrier/.gitignore
> > new file mode 100644
> > index 0000000..020c44f4
> > --- /dev/null
> > +++ b/tools/testing/selftests/membarrier/.gitignore
> > @@ -0,0 +1 @@
> > +membarrier_test
> > diff --git a/tools/testing/selftests/membarrier/Makefile
> > b/tools/testing/selftests/membarrier/Makefile
> > new file mode 100644
> > index 0000000..752b719
> > --- /dev/null
> > +++ b/tools/testing/selftests/membarrier/Makefile
> > @@ -0,0 +1,13 @@
> > +CFLAGS += -g -D_FILE_OFFSET_BITS=64
> > +CFLAGS += -I../../../../include/uapi/
> > +CFLAGS += -I../../../../include/
> 
> Don't include the kernel headers, this is userspace.
> 
> If you want to include the exported headers that would be good, they are in
> ../../../../usr/include by default.
> 
> > +all:
> > +	gcc $(CFLAGS) membarrier_test.c -o membarrier_test
> > +
> > +run_tests: all
> > +	gcc $(CFLAGS) membarrier_test.c -o membarrier_test
> > +	@./membarrier_test || echo "membarrier_test: [FAIL]"
> > +
> > +clean:
> > +	$(RM) membarrier_test
> 
> Can you please use lib.mk, it will do most of this for you, will support
> cross
> compilation, and install support as well.

Allright, Pranith sent me an updated patch handling those issues,
and I queued one extra patch updating the selftest on top of his
work. I'll CC you on the next round for those 2 patches.

Thanks!

Mathieu

> 
> cheers
> 
> 
> 

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com