From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 31/32] drm/i915/execlists: Virtual engine bonding Date: Thu, 18 Apr 2019 11:24:40 +0100 Message-ID: <673d2d50-ae0a-428b-eaa0-71719e0aede1@linux.intel.com> References: <20190417075657.19456-1-chris@chris-wilson.co.uk> <20190417075657.19456-31-chris@chris-wilson.co.uk> <155557065786.3649.15598309807699098369@skylake-alporthouse-com> <155557882725.4314.8046103585634106323@skylake-alporthouse-com> <155558156269.4314.1903788784014193441@skylake-alporthouse-com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2F6CB6E028 for ; Thu, 18 Apr 2019 10:24:43 +0000 (UTC) In-Reply-To: <155558156269.4314.1903788784014193441@skylake-alporthouse-com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE4LzA0LzIwMTkgMTA6NTksIENocmlzIFdpbHNvbiB3cm90ZToKPiBRdW90aW5nIFR2cnRr byBVcnN1bGluICgyMDE5LTA0LTE4IDEwOjUwOjMwKQo+Pgo+PiBPbiAxOC8wNC8yMDE5IDEwOjEz LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+PiBRdW90aW5nIFR2cnRrbyBVcnN1bGluICgyMDE5LTA0 LTE4IDA5OjU3OjQzKQo+Pj4+Cj4+Pj4gT24gMTgvMDQvMjAxOSAwNzo1NywgQ2hyaXMgV2lsc29u IHdyb3RlOgo+Pj4+PiBRdW90aW5nIFR2cnRrbyBVcnN1bGluICgyMDE5LTA0LTE4IDA3OjQ3OjUx KQo+Pj4+Pj4KPj4+Pj4+IE9uIDE3LzA0LzIwMTkgMDg6NTYsIENocmlzIFdpbHNvbiB3cm90ZToK Pj4+Pj4+PiArc3RhdGljIHZvaWQKPj4+Pj4+PiArdmlydHVhbF9ib25kX2V4ZWN1dGUoc3RydWN0 IGk5MTVfcmVxdWVzdCAqcnEsIHN0cnVjdCBkbWFfZmVuY2UgKnNpZ25hbCkKPj4+Pj4+PiArewo+ Pj4+Pj4+ICsgICAgIHN0cnVjdCB2aXJ0dWFsX2VuZ2luZSAqdmUgPSB0b192aXJ0dWFsX2VuZ2lu ZShycS0+ZW5naW5lKTsKPj4+Pj4+PiArICAgICBzdHJ1Y3QgdmVfYm9uZCAqYm9uZDsKPj4+Pj4+ PiArCj4+Pj4+Pj4gKyAgICAgYm9uZCA9IHZpcnR1YWxfZmluZF9ib25kKHZlLCB0b19yZXF1ZXN0 KHNpZ25hbCktPmVuZ2luZSk7Cj4+Pj4+Pj4gKyAgICAgaWYgKGJvbmQpIHsKPj4+Pj4+PiArICAg ICAgICAgICAgIGludGVsX2VuZ2luZV9tYXNrX3Qgb2xkLCBuZXcsIGNtcDsKPj4+Pj4+PiArCj4+ Pj4+Pj4gKyAgICAgICAgICAgICBjbXAgPSBSRUFEX09OQ0UocnEtPmV4ZWN1dGlvbl9tYXNrKTsK Pj4+Pj4+PiArICAgICAgICAgICAgIGRvIHsKPj4+Pj4+PiArICAgICAgICAgICAgICAgICAgICAg b2xkID0gY21wOwo+Pj4+Pj4+ICsgICAgICAgICAgICAgICAgICAgICBuZXcgPSBjbXAgJiBib25k LT5zaWJsaW5nX21hc2s7Cj4+Pj4+Pj4gKyAgICAgICAgICAgICB9IHdoaWxlICgoY21wID0gY21w eGNoZygmcnEtPmV4ZWN1dGlvbl9tYXNrLCBvbGQsIG5ldykpICE9IG9sZCk7Cj4+Pj4+Pgo+Pj4+ Pj4gTG9vcCBpbXBsaWVzIHNvbWVvbmUgZWxzZSBtaWdodCBiZSBtb2RpZnlpbmcgdGhlIHJxLT5l eGVjdXRpb25fbWFzayBpbgo+Pj4+Pj4gcGFyYWxsZWw/Cj4+Pj4+Cj4+Pj4+IFRoZXJlJ3Mgbm90 aGluZyB0aGF0IHByZXZlbnRzIHRoZXJlIGJlaW5nIG11bHRpcGxlIGJvbmRzIGJlaW5nCj4+Pj4+ IGV4ZWN1dGVkIHNpbXVsdGFuZW91c2x5IChvdGhlciB0aGFuIHByYWN0aWNhbGl0eSkuIFRoZXJl J3MgYWxzbyBub3RoaW5nCj4+Pj4+IHRoYXQgc2F5cyB0aGlzIHNob3VsZCBiZSB0aGUgb25seSB3 YXkgdG8gbW9kaWZ5IHJxLT5leGVjdXRpb25fbWFzayBpbgo+Pj4+PiB0aGUgZnV0dXJlLgo+Pj4+ Cj4+Pj4gQnV0IHJlcXVlc3QgaXMgb25lLCBob3cgY2FuIGl0IGJlIHN1Ym1pdHRlZCBtdWx0aXBs ZSB0aW1lcyBzaW11bHRhbmVvdXNseT8KPj4+Cj4+PiBZb3UgbWVhbiAiSG93IGNhbiBpdCBiZSBz aWduYWxlZCBtdWx0aXBsZSB0aW1lcyBzaW11bHRhbmVvdXNseT8iCj4+Cj4+IE9rYXkgeWVzLCBz aWduYWxlZC4gWW91IGNvdWxkIGdpdmUgc2FtZSBzdWJtaXQgZmVuY2UgdG8gbXVsdGlwbGUgc2xh dmVzLAo+PiBidXQgeW91IGNhbid0IGhhdmUgc2FtZSBzbGF2ZSByZXF1ZXN0IHJlY2VpdmUgbm90 aWZpY2F0aW9uIGZyb20gbXVsdGlwbGUKPj4gbWFzdGVycy4KPj4KPj4gT3IgeW91IGNhbiBpZiB5 b3UgYnVpbGQgYSBjb21wb3NpdGUgZmVuY2UgYW5kIHBhc3MgdGhhdCBpbj8gSXMgdGhpcyB0aGUK Pj4gc3RvcnkgYWJvdXQgc2lnbmFsLW9uLWFueSB2cyBzaWduYWwtb24tYWxsPwo+IAo+IFRoZXJl J3Mgbm90aGluZyBpbmhlcmVudCBpbiB0aGUgZGVzaWduIHRvIHByZXZlbnQgdmlydHVhbF9ib25k X2V4ZWN1dGUKPiBiZWluZyBjYWxsZWQgbXVsdGlwbGUgdGltZXMgZ2l2ZW4gbXVsdGlwbGUgZmVu Y2VzIGFsb25nIG9uZSBvciBtb3JlCj4gZW5naW5lcy4KPiAKPiBUaGVyZSdzIGEgcHJhY3RpY2Fs IGxpbWl0YXRpb24gaW4gdGhlIHByb3Bvc2VkIHVBUEkgdG8gbGltaXQgaXQgdG8gYQo+IHNpbmds ZSBzdWJtaXQtZmVuY2UsIGJ1dCBtYXkgaW5kZWVkIGJlIGEgY29tcG9zaXRlIGZlbmNlLiBUaGVy ZSdzIGFsc28KPiB0aGUgcXVlc3Rpb24gb2Ygd2hldGhlciB0byBzcXVlZXplIGluIHN5bmNvYmog c3VwcG9ydC4KCk9rLiBKdXN0IGRyb3AgaW4gYSBjb21tZW50IHdpdGggdGhlIGxvb3AgcGxlYXNl LgoKPj4+Pj4+PiArCj4+Pj4+Pj4gKyAgICAgZXJyID0gY2hlY2tfdXNlcl9tYnooJmV4dC0+Zmxh Z3MpOwo+Pj4+Pj4+ICsgICAgIGlmIChlcnIpCj4+Pj4+Pj4gKyAgICAgICAgICAgICByZXR1cm4g ZXJyOwo+Pj4+Pj4+ICsKPj4+Pj4+PiArICAgICBmb3IgKG4gPSAwOyBuIDwgQVJSQVlfU0laRShl eHQtPm1iejY0KTsgbisrKSB7Cj4+Pj4+Pj4gKyAgICAgICAgICAgICBlcnIgPSBjaGVja191c2Vy X21ieigmZXh0LT5tYno2NFtuXSk7Cj4+Pj4+Pj4gKyAgICAgICAgICAgICBpZiAoZXJyKQo+Pj4+ Pj4+ICsgICAgICAgICAgICAgICAgICAgICByZXR1cm4gZXJyOwo+Pj4+Pj4+ICsgICAgIH0KPj4+ Pj4+PiArCj4+Pj4+Pj4gKyAgICAgaWYgKGdldF91c2VyKGNsYXNzLCAmZXh0LT5tYXN0ZXJfY2xh c3MpKQo+Pj4+Pj4+ICsgICAgICAgICAgICAgcmV0dXJuIC1FRkFVTFQ7Cj4+Pj4+Pj4gKwo+Pj4+ Pj4+ICsgICAgIGlmIChnZXRfdXNlcihpbnN0YW5jZSwgJmV4dC0+bWFzdGVyX2luc3RhbmNlKSkK Pj4+Pj4+PiArICAgICAgICAgICAgIHJldHVybiAtRUZBVUxUOwo+Pj4+Pj4+ICsKPj4+Pj4+PiAr ICAgICBtYXN0ZXIgPSBpbnRlbF9lbmdpbmVfbG9va3VwX3VzZXIoc2V0LT5jdHgtPmk5MTUsIGNs YXNzLCBpbnN0YW5jZSk7Cj4+Pj4+Pj4gKyAgICAgaWYgKCFtYXN0ZXIpIHsKPj4+Pj4+PiArICAg ICAgICAgICAgIERSTV9ERUJVRygiVW5yZWNvZ25pc2VkIG1hc3RlciBlbmdpbmU6IHsgY2xhc3M6 JWQsIGluc3RhbmNlOiVkIH1cbiIsCj4+Pj4+Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgY2xh c3MsIGluc3RhbmNlKTsKPj4+Pj4+PiArICAgICAgICAgICAgIHJldHVybiAtRUlOVkFMOwo+Pj4+ Pj4+ICsgICAgIH0KPj4+Pj4+PiArCj4+Pj4+Pj4gKyAgICAgaWYgKGdldF91c2VyKG51bV9ib25k cywgJmV4dC0+bnVtX2JvbmRzKSkKPj4+Pj4+PiArICAgICAgICAgICAgIHJldHVybiAtRUZBVUxU Owo+Pj4+Pj4KPj4+Pj4+IFNob3VsZCBudW1fYm9uZHMgPiB2aXJ0dWFsLT5udW1fc2libGluZ3Mg YmUgYW4gZXJyb3I/Cj4+Pj4+Cj4+Pj4+IFRoZXkgY291bGQgc3BlY2lmeSB0aGUgc2FtZSBib25k IG11bHRpcGxlIHRpbWVzIGZvciB3aGF0ZXZlciByZWFzb24gKGFuZAo+Pj4+PiBwcm9iYWJseSBz aG91bGQgYWxsb3cgc2tpcHBpbmcgTk9ORT8pLCBpZiB0aGUgdGFyZ2V0IGRvZXNuJ3QgZXhpc3Qg dGhhdCdzCj4+Pj4+IGRlZmluaXRlbHkgYW4gZXJyb3IuCj4+Pj4KPj4+PiBTbyB3aGljaCBib25k IHdlIHBpY2sgaWYgdGhleSBzcGVjaWZ5IG11bHRpcGxlIG9uZXM/IEp1c3QgdGhlIGZpcnN0IG9u ZQo+Pj4+IGZvdW5kLiBIbSBhY3R1YWxseSBJIHdhcyB0aGlua2luZyBhYm91dCBtYWtpbmcgc3Vy ZSBlYWNoIG1hc3RlciBpcyBvbmx5Cj4+Pj4gc3BlY2lmaWVkIG9uY2UsIG5vdCBzaWJsaW5ncy4g Rm9yIHNpYmxpbmdzIHdlIGluZGVlZCBkbyBub3QgY2FyZS4KPj4+Cj4+PiBObywgaXQncyBhIG1h c2sgb2YgaWYgcGFyZW50IGV4ZWN1dGVzIG9uIG1hc3RlciwgdXNlIHRoaXMgc2V0IG9mCj4+PiBj aGlsZHJlbi4KPj4+Cj4+PiBJIHdhcyByZWFzb25hYmx5IGhhcHB5IHRvIHVzZSBhIGN1bXVsYXRp dmUgbWFzayBpZiBtYXN0ZXIgaXMgc3BlY2lmaWVkCj4+PiBieSBtb3JlIHRoYW4gb25lIGJvbmQg ZXh0OyBidXQgbWF5YmUgaXQgc2hvdWxkIGJlIGFuIGludGVyc2VjdGlvbi4gSG1tLgo+Pgo+PiBE byB5b3Ugc2VlIGEgcmVhbGlzdGljIGFuZCBtYWtpbmcgc2Vuc2UgdXNlIGNhc2UgZm9yIHNwZWNp ZnlpbmcgdGhlIHNhbWUKPj4gbWFzdGVyIGluIG11bHRpcGxlIGJvbmRzPyBJZiBub3QgSSdkIGp1 c3QgZGlzYWxsb3cgaXQgYW5kIHRoZW4gd2UgZG9uJ3QKPj4gaGF2ZSBhIHF1ZXN0aW9uIG9mIHVu aW9uIHZzIGludGVyc2VjdGlvbiBwb2xpY3kuCj4gCj4gUmF0aGVyIHRoZSBvcHBvc2l0ZSwgSSBk b24ndCBzZWUgdGhhdCBpdCBicmVha3MgYW55dGhpbmcgbm9yIG5lZWQgaXQgYmUKPiBpbGwtZGVm aW5lZCwgaGVuY2Ugbm8gcmVhc29uIHRvIHJlamVjdCBhcyBhIG1lYW5zIHRvIHByb3RlY3Qgb25l c2VsZi4KCkkgZG9uJ3QgbWVhbiBpdCdzIGRhbmdlcm91cyBvciBwb29ybHkgZGVmaW5lZC4gSW4g dGhhdCBzZW5zZSB5b3VyIApjdXJyZW50IGltcGxlbWVudGF0aW9uIG9mIHVzaW5nIGFuIHVuaW9u IGlzIGZpbmUuIChFYXJsaWVyIEkgZm9yZ290IHRoYXQgCnlvdSBza2lwIGNyZWF0aW5nIG11bHRp cGxlIGJvbmQgb2JqZWN0cyBpbiB0aGlzIGNhc2UuKQoKUmVnYXJkcywKClR2cnRrbwpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGlu ZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=