From: John Fastabend <john.fastabend@gmail.com>
To: zijianzhang@bytedance.com, bpf@vger.kernel.org
Cc: edumazet@google.com, john.fastabend@gmail.com,
jakub@cloudflare.com, davem@davemloft.net, dsahern@kernel.org,
kuba@kernel.org, pabeni@redhat.com, ast@kernel.org,
daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev,
eddyz87@gmail.com, song@kernel.org, yonghong.song@linux.dev,
kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com,
jolsa@kernel.org, mykolal@fb.com, shuah@kernel.org,
wangyufen@huawei.com, xiyou.wangcong@gmail.com,
zijianzhang@bytedance.com
Subject: RE: [PATCH bpf 1/2] selftests/bpf: Add apply_bytes test to test_txmsg_redir_wait_sndmem in test_sockmap
Date: Wed, 20 Nov 2024 21:38:14 -0800 [thread overview]
Message-ID: <673ec74681e52_157a2083d@john.notmuch> (raw)
In-Reply-To: <20241016234838.3167769-2-zijianzhang@bytedance.com>
zijianzhang@ wrote:
> From: Zijian Zhang <zijianzhang@bytedance.com>
>
> Add this to more comprehensively test the socket memory accounting logic
> in the __SK_REDIRECT and __SK_DROP cases of tcp_bpf_sendmsg. We don't have
> test when apply_bytes are not zero in test_txmsg_redir_wait_sndmem.
> test_send_large has opt->rate=2, it will invoke sendmsg two times.
> Specifically, the first sendmsg will trigger the case where the ret value
> of tcp_bpf_sendmsg_redir is less than 0; while the second sendmsg happens
> after the 3 seconds timeout, and it will trigger __SK_DROP because socket
> c2 has been removed from the sockmap/hash.
>
> Signed-off-by: Zijian Zhang <zijianzhang@bytedance.com>
> ---
Thanks, sorry for the rather long delay.
Acked-by: John Fastabend <john.fastabend@gmail.com>
next prev parent reply other threads:[~2024-11-21 5:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 23:48 [PATCH bpf 0/2] tcp_bpf: Fix the sk_mem_uncharge logic in tcp_bpf_sendmsg zijianzhang
2024-10-16 23:48 ` [PATCH bpf 1/2] selftests/bpf: Add apply_bytes test to test_txmsg_redir_wait_sndmem in test_sockmap zijianzhang
2024-11-21 5:38 ` John Fastabend [this message]
2024-10-16 23:48 ` [PATCH bpf 2/2] tcp_bpf: Fix the sk_mem_uncharge logic in tcp_bpf_sendmsg zijianzhang
2024-11-21 5:43 ` John Fastabend
2024-11-21 5:49 ` [PATCH bpf 0/2] " John Fastabend
2024-11-26 19:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=673ec74681e52_157a2083d@john.notmuch \
--to=john.fastabend@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=eddyz87@gmail.com \
--cc=edumazet@google.com \
--cc=haoluo@google.com \
--cc=jakub@cloudflare.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=martin.lau@linux.dev \
--cc=mykolal@fb.com \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=wangyufen@huawei.com \
--cc=xiyou.wangcong@gmail.com \
--cc=yonghong.song@linux.dev \
--cc=zijianzhang@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.