From: John Fastabend <john.fastabend@gmail.com>
To: Amir Mohammadi <amirmohammadi1999.am@gmail.com>,
qmo@kernel.org, ast@kernel.org, daniel@iogearbox.net,
andrii@kernel.org, martin.lau@linux.dev, eddyz87@gmail.com,
song@kernel.org, yonghong.song@linux.dev,
john.fastabend@gmail.com, kpsingh@kernel.org, sdf@fomichev.me,
haoluo@google.com, jolsa@kernel.org, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Amir Mohammadi <amiremohamadi@yahoo.com>
Subject: RE: [PATCH v2] bpftool: fix potential NULL pointer dereferencing in prog_dump()
Date: Wed, 20 Nov 2024 22:34:47 -0800 [thread overview]
Message-ID: <673ed487b45f4_157a208ab@john.notmuch> (raw)
In-Reply-To: <20241116071346.1412266-1-amiremohamadi@yahoo.com>
Amir Mohammadi wrote:
> A NULL pointer dereference could occur if ksyms
> is not properly checked before usage in the prog_dump() function.
>
> Signed-off-by: Amir Mohammadi <amiremohamadi@yahoo.com>
> ---
> tools/bpf/bpftool/prog.c | 17 ++++++++++++-----
> 1 file changed, 12 insertions(+), 5 deletions(-)
LGTM but still needs a Fixes line.
next prev parent reply other threads:[~2024-11-21 6:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-15 11:45 [PATCH] bpftool: fix potential NULL pointer dereferencing in prog_dump() Amir Mohammadi
2024-11-15 13:42 ` Quentin Monnet
2024-11-16 7:13 ` [PATCH v2] " Amir Mohammadi
2024-11-21 6:34 ` John Fastabend [this message]
2024-11-21 8:34 ` [PATCH v3] " Amir Mohammadi
2024-11-21 11:18 ` Quentin Monnet
2024-11-21 23:29 ` John Fastabend
2024-11-25 22:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=673ed487b45f4_157a208ab@john.notmuch \
--to=john.fastabend@gmail.com \
--cc=amiremohamadi@yahoo.com \
--cc=amirmohammadi1999.am@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=qmo@kernel.org \
--cc=sdf@fomichev.me \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.