From: John Fastabend <john.fastabend@gmail.com>
To: Michal Luczaj <mhal@rbox.co>,
Stefano Garzarella <sgarzare@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Bobby Eshleman <bobby.eshleman@bytedance.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
Eduard Zingerman <eddyz87@gmail.com>,
Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>,
Hao Luo <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>,
Mykola Lysenko <mykolal@fb.com>, Shuah Khan <shuah@kernel.org>
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org,
linux-kselftest@vger.kernel.org, Michal Luczaj <mhal@rbox.co>
Subject: RE: [PATCH bpf 0/4] bpf, vsock: Fix poll() and close()
Date: Wed, 20 Nov 2024 22:48:25 -0800 [thread overview]
Message-ID: <673ed7b929dbe_157a2089e@john.notmuch> (raw)
In-Reply-To: <20241118-vsock-bpf-poll-close-v1-0-f1b9669cacdc@rbox.co>
Michal Luczaj wrote:
> Two small fixes for vsock: poll() missing a queue check, and close() not
> invoking sockmap cleanup.
>
> Signed-off-by: Michal Luczaj <mhal@rbox.co>
> ---
> Michal Luczaj (4):
> bpf, vsock: Fix poll() missing a queue
> selftest/bpf: Add test for af_vsock poll()
> bpf, vsock: Invoke proto::close on close()
> selftest/bpf: Add test for vsock removal from sockmap on close()
>
> net/vmw_vsock/af_vsock.c | 70 ++++++++++++--------
> .../selftests/bpf/prog_tests/sockmap_basic.c | 77 ++++++++++++++++++++++
> 2 files changed, 120 insertions(+), 27 deletions(-)
> ---
> base-commit: 6c4139b0f19b7397286897caee379f8321e78272
> change-id: 20241118-vsock-bpf-poll-close-64f432e682ec
>
> Best regards,
> --
> Michal Luczaj <mhal@rbox.co>
>
LGTM, would be nice to get an ack from someone on the vsock side
though.
Acked-by: John Fastabend <john.fastabend@gmail.com>
next prev parent reply other threads:[~2024-11-21 6:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-18 21:03 [PATCH bpf 0/4] bpf, vsock: Fix poll() and close() Michal Luczaj
2024-11-18 21:03 ` [PATCH bpf 1/4] bpf, vsock: Fix poll() missing a queue Michal Luczaj
2024-11-21 9:20 ` Stefano Garzarella
2024-11-22 17:26 ` Luigi Leonardi
2024-11-18 21:03 ` [PATCH bpf 2/4] selftest/bpf: Add test for af_vsock poll() Michal Luczaj
2024-11-21 9:21 ` Stefano Garzarella
2024-11-18 21:03 ` [PATCH bpf 3/4] bpf, vsock: Invoke proto::close on close() Michal Luczaj
2024-11-21 9:22 ` Stefano Garzarella
2024-11-21 19:54 ` Michal Luczaj
2024-11-22 8:13 ` Stefano Garzarella
2024-11-22 16:20 ` Luigi Leonardi
2024-11-18 21:03 ` [PATCH bpf 4/4] selftest/bpf: Add test for vsock removal from sockmap " Michal Luczaj
2024-11-21 9:22 ` Stefano Garzarella
2024-11-21 6:48 ` John Fastabend [this message]
2024-11-21 8:08 ` [PATCH bpf 0/4] bpf, vsock: Fix poll() and close() Stefano Garzarella
2024-11-21 23:34 ` John Fastabend
2024-11-22 8:16 ` Stefano Garzarella
2024-11-25 22:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=673ed7b929dbe_157a2089e@john.notmuch \
--to=john.fastabend@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bobby.eshleman@bytedance.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=eddyz87@gmail.com \
--cc=edumazet@google.com \
--cc=haoluo@google.com \
--cc=horms@kernel.org \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=mhal@rbox.co \
--cc=mst@redhat.com \
--cc=mykolal@fb.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=sgarzare@redhat.com \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.