From: Christian Marangi <ansuelsmth@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, upstream@airoha.com
Subject: Re: [PATCH v4 2/2] cpufreq: airoha: Add EN7581 CPUFreq SMCCC driver
Date: Mon, 2 Dec 2024 21:47:58 +0100 [thread overview]
Message-ID: <674e1d02.050a0220.8873f.0e43@mx.google.com> (raw)
In-Reply-To: <ktzz2btcxjlt7l36k7pgv4widhw45p44ol4hr2kjrf6ui62fjk@2yfvkmvdyk73>
On Mon, Dec 02, 2024 at 09:38:10PM +0100, Uwe Kleine-König wrote:
> hello,
>
> On Mon, Dec 02, 2024 at 04:12:04PM +0100, Christian Marangi wrote:
> > +static struct platform_driver airoha_cpufreq_driver = {
> > + .probe = airoha_cpufreq_probe,
> > + .remove_new = airoha_cpufreq_remove,
>
> That doesn't build on top of mainline since commit e70140ba0d2b ("Get rid of 'remove_new' relic from platform driver struct")
>
> Please use .remove.
>
Hi Uwe,
I rebased this on top of next and still compiled but yes sorry it's a
leftover from testing this also on my OpenWrt buildroot. (seems the
commit still needs to be merged)
Maybe you can point me what branch/repository I should target?
Did you notice other problem with the changes? I notice the PD
implementation changed recently.
--
Ansuel
next prev parent reply other threads:[~2024-12-02 20:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-02 15:12 [PATCH v4 1/2] dt-bindings: cpufreq: Document support for Airoha EN7581 CPUFreq Christian Marangi
2024-12-02 15:12 ` [PATCH v4 2/2] cpufreq: airoha: Add EN7581 CPUFreq SMCCC driver Christian Marangi
2024-12-02 20:38 ` Uwe Kleine-König
2024-12-02 20:47 ` Christian Marangi [this message]
2024-12-03 7:44 ` Uwe Kleine-König
2024-12-02 15:42 ` [PATCH v4 1/2] dt-bindings: cpufreq: Document support for Airoha EN7581 CPUFreq Ulf Hansson
2024-12-02 15:45 ` Christian Marangi
2024-12-02 20:57 ` Rob Herring
2024-12-02 20:59 ` Christian Marangi
2024-12-03 10:36 ` Ulf Hansson
2024-12-03 10:33 ` Ulf Hansson
2024-12-03 10:47 ` Christian Marangi
2024-12-03 10:50 ` Viresh Kumar
2024-12-02 16:16 ` Rob Herring (Arm)
2024-12-03 4:41 ` Viresh Kumar
2024-12-03 10:22 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=674e1d02.050a0220.8873f.0e43@mx.google.com \
--to=ansuelsmth@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=u.kleine-koenig@baylibre.com \
--cc=upstream@airoha.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.