Re: [PATCH v1 1/1] fitimage: Add support for custom compatible string via optional parameter

["Kavinaya S" <kavinaya@qti.qualcomm.com>]

On Mon, Sep 29, 2025 at 08:26 PM, Alexander Kanavin wrote:

>
> COMPATIBLE is really not an appropriate name. It should be much more
> specific, e.g. DTB_CUSTOM_COMPATIBLE, or something even more detailed.
> 
Hi Alex, Sure. I will update COMPATIBLE to DTB_CUSTOM_COMPATIBLE
> > 
> > - dtbo_loadaddress=None, add_compatible=False):
> > + dtbo_loadaddress=None, add_compatible=False, custom_compatible=False):
> 
> custom_compatible is not a boolean parameter, it's a string. If it
> isn't supplied, set the default to None.
> 
Sure
> > 
> > if add_compatible:
> > - compatible = get_compatible_from_dtb(dtb_path)
> > + if custom_compatible:
> > + # Accept either a string (space-separated) or an iterable of strings
> > + if isinstance(custom_compatible, (list, tuple)):
> > + compatible = list(custom_compatible)
> > + else:
> > + compatible = str(custom_compatible).split()
> 
> I don't understand. d.getVar() returns a string. At which point
> custom_compatible turns into a list or a tuple?
> 
I will update this logic as well.
> That's why I had asked you to also make tests for this feature.
>
I will add tests as well.
Thanks 
Alex