Re: [PATCH] build: fix missing crypto vec limits in version

[Thomas Monjalon <thomas@monjalon.net>]

17/01/2023 17:25, Jerin Jacob:
> On Tue, Dec 6, 2022 at 2:58 PM Zhang, Fan <fanzhang.oss@gmail.com> wrote:
> >
> > On 12/6/2022 9:23 AM, Volodymyr Fialko wrote:
> > > Add missing function `rte_event_crypto_adapter_vector_limits_get` to
> > > version.map.
> > >
> > > Fixes: c1749bc5ee10 ("eventdev: introduce event cryptodev vector type")
> > >
> > > Signed-off-by: Volodymyr Fialko <vfialko@marvell.com>
> > > ---
> > >   lib/eventdev/version.map | 1 +
> > >   1 file changed, 1 insertion(+)
> > >
> > > diff --git a/lib/eventdev/version.map b/lib/eventdev/version.map
> > > index dd63ec6f68..1a7fffd17f 100644
> > > --- a/lib/eventdev/version.map
> > > +++ b/lib/eventdev/version.map
> > > @@ -20,6 +20,7 @@ DPDK_23 {
> > >       rte_event_crypto_adapter_stats_get;
> > >       rte_event_crypto_adapter_stats_reset;
> > >       rte_event_crypto_adapter_stop;
> > > +     rte_event_crypto_adapter_vector_limits_get;
> > >       rte_event_dequeue_timeout_ticks;
> > >       rte_event_dev_attr_get;
> > >       rte_event_dev_close;
> > Acked-by: Fan Zhang <fanzhang.oss@gmail.com>
> 
> + @Thomas Monjalon  @David Marchand
> 
> 1) Sanity is failing as follows
> ### [PATCH] build: fix missing crypto vec limits in version
> 
> ERROR: symbol rte_event_crypto_adapter_vector_limits_get is added in
> the DPDK_23 section, but is expected to be added in the EXPERIMENTAL
> section of the version map
> 
> This patch is added in 22.07. New patches should be experimental.
> Right? If so, Please change to __rte_experimental and move
> EXPERIMENTAL section. If  I am not missing anything.

Yes new functions should be experimental.
You need to add a comment in the .h
and the attribute __rte_experimental.

Such issue would have been seen earlier if the new function
was used in a unit test or a test application.