From: Fernando Fernandez Mancera <fmancera@suse.de>
To: luka.gejak@linux.dev, netdev@vger.kernel.org
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, fmaurer@redhat.com
Subject: Re: [PATCH net-next v6 1/2] net: hsr: require valid EOT supervision TLV
Date: Thu, 14 May 2026 14:55:15 +0200 [thread overview]
Message-ID: <6755adfa-9a28-46cd-84f1-747082d0f71f@suse.de> (raw)
In-Reply-To: <20260513182657.20346-2-luka.gejak@linux.dev>
On 5/13/26 8:26 PM, luka.gejak@linux.dev wrote:
> From: Luka Gejak <luka.gejak@linux.dev>
>
> Supervision frames are only valid if terminated with a zero-length EOT
> TLV. The current check fails to reject non-EOT entries as the terminal
> TLV, potentially allowing malformed supervision traffic.
>
> Fix this by strictly requiring the terminal TLV to be HSR_TLV_EOT
> with a length of zero, and properly linearizing the TLV header before
> access.
>
> Assisted-by: Gemini:Gemini-3.1-flash
> Signed-off-by: Luka Gejak <luka.gejak@linux.dev>
Reviewed-by: Fernando Fernandez Mancera <fmancera@suse.de>
next prev parent reply other threads:[~2026-05-14 12:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 18:26 [PATCH net-next v6 0/2] net: hsr: strict supervision TLV validation luka.gejak
2026-05-13 18:26 ` [PATCH net-next v6 1/2] net: hsr: require valid EOT supervision TLV luka.gejak
2026-05-14 12:55 ` Fernando Fernandez Mancera [this message]
2026-05-16 0:33 ` Jakub Kicinski
2026-05-13 18:26 ` [PATCH net-next v6 2/2] net: hsr: reject unresolved interlink ifindex luka.gejak
2026-05-14 12:55 ` Fernando Fernandez Mancera
2026-05-13 18:35 ` [PATCH net-next v6 0/2] net: hsr: strict supervision TLV validation Luka Gejak
2026-05-16 0:40 ` patchwork-bot+netdevbpf
-- strict thread matches above, loose matches on Subject: below --
2026-04-13 10:34 luka.gejak
2026-04-13 10:34 ` [PATCH net-next v6 1/2] net: hsr: require valid EOT supervision TLV luka.gejak
2026-04-13 10:57 ` Felix Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6755adfa-9a28-46cd-84f1-747082d0f71f@suse.de \
--to=fmancera@suse.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fmaurer@redhat.com \
--cc=kuba@kernel.org \
--cc=luka.gejak@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.