Re: [PATCH 3/4] powerpc: mpc83xx: Use defined constant for SPCR[TBEN]

[Sinan Akman <sinan@writeme.com>]

On 2024-12-15 10:18, J. Neuschäfer via B4 Relay wrote:
> From: "J. Neuschäfer"<j.ne@posteo.net>
>
> To increase readability, use the defined constant instead of specifying
> SPCR[TBEN] as a number.
>
> Signed-off-by: J. Neuschäfer<j.ne@posteo.net>
> ---
>   arch/powerpc/cpu/mpc83xx/interrupts.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/cpu/mpc83xx/interrupts.c b/arch/powerpc/cpu/mpc83xx/interrupts.c
> index af517213f176cf59cc82b54dbe5247800a6c40e6..bb37a1332c877951e766a8891687dae3f05b6ef8 100644
> --- a/arch/powerpc/cpu/mpc83xx/interrupts.c
> +++ b/arch/powerpc/cpu/mpc83xx/interrupts.c
> @@ -12,6 +12,7 @@
>   #include <asm/global_data.h>
>   #include <asm/processor.h>
>   #include <asm/ptrace.h>
> +#include "initreg/initreg.h"
>
>   DECLARE_GLOBAL_DATA_PTR;
>
> @@ -29,7 +30,7 @@ void interrupt_init_cpu (unsigned *decrementer_count)
>
>   	/* Enable e300 time base */
>
> -	immr->sysconf.spcr |= 0x00400000;
> +	immr->sysconf.spcr |= SPCR_TBEN_MASK;
>   }
>
>   /*
>

Reviewed-by: Sinan Akman <sinan@writeme.com>